Fabio/Auxio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

musikr.graph: dont simplify size-1 clusters

Browse source 
Creates very hard to trace bugs.
This commit is contained in:
Alexander Capehart 2024-12-16 15:47:59 -05:00
parent 9d1978850b
commit 4421f4f56d
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
musikr/src/main/java/org/oxycblt/musikr/graph/MusicGraph.kt
View file

@ -137,6 +137,10 @@ private class MusicGraphBuilderImpl : MusicGraph.Builder {
}
private fun simplifyGenreCluster(cluster: Collection<GenreVertex>) {
if (cluster.size == 1) {
// Nothing to do.
return
}
// All of these genres are semantically equivalent. Pick the most popular variation
// and merge all the others into it.
val clusterSet = cluster.toMutableSet()
@ -166,6 +170,10 @@ private class MusicGraphBuilderImpl : MusicGraph.Builder {
}
private fun simplifyArtistCluster(cluster: Collection<ArtistVertex>) {
if (cluster.size == 1) {
// Nothing to do.
return
}
val fullMusicBrainzIdCoverage = cluster.all { it.preArtist.musicBrainzId != null }
if (fullMusicBrainzIdCoverage) {
// All artists have MBIDs, nothing needs to be merged.
@ -225,6 +233,10 @@ private class MusicGraphBuilderImpl : MusicGraph.Builder {
}
private fun simplifyAlbumCluster(cluster: Collection<AlbumVertex>) {
if (cluster.size == 1) {
// Nothing to do.
return;
}
val fullMusicBrainzIdCoverage = cluster.all { it.preAlbum.musicBrainzId != null }
if (fullMusicBrainzIdCoverage) {
// All albums have MBIDs, nothing needs to be merged.
@ -251,6 +263,10 @@ private class MusicGraphBuilderImpl : MusicGraph.Builder {
private fun simplifyAlbumClusterImpl(cluster: Collection<AlbumVertex>) {
// All of these albums are semantically equivalent. Pick the most popular variation
// and merge all the others into it.
if (cluster.size == 1) {
// Nothing to do.
return
}
val clusterSet = cluster.toMutableSet()
val dst = clusterSet.maxBy { it.songVertices.size }
clusterSet.remove(dst)