all: update todos

This commit is contained in:
Alexander Capehart 2024-12-23 17:13:55 -05:00
parent 258418578a
commit 9a7b970346
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
5 changed files with 6 additions and 9 deletions

View file

@ -404,9 +404,6 @@ class MainFragment :
} }
private fun updateIndexerState(state: IndexingState?) { private fun updateIndexerState(state: IndexingState?) {
// TODO: Make music loading experience a bit more pleasant
// 1. Loading placeholder for item lists
// 2. Rework the "No Music" case to not be an error and instead result in a placeholder
if (state is IndexingState.Completed && state.error == null) { if (state is IndexingState.Completed && state.error == null) {
L.d("Received ok response") L.d("Received ok response")
val binding = requireBinding() val binding = requireBinding()

View file

@ -313,9 +313,8 @@ class HomeFragment :
} }
private fun updateIndexerState(state: IndexingState?) { private fun updateIndexerState(state: IndexingState?) {
// TODO: Make music loading experience a bit more pleasant // TODO: Reduce intrusiveness of current loading state:
// 1. Loading placeholder for item lists // 1. "Dry" loads
// 2. Rework the "No Music" case to not be an error and instead result in a placeholder
val binding = requireBinding() val binding = requireBinding()
when (state) { when (state) {
is IndexingState.Completed -> setupCompleteState(binding, state.error) is IndexingState.Completed -> setupCompleteState(binding, state.error)

View file

@ -66,7 +66,6 @@ import org.oxycblt.auxio.util.systemBarInsetsCompat
* @author Hai Zhang, Alexander Capehart (OxygenCobalt) * @author Hai Zhang, Alexander Capehart (OxygenCobalt)
* *
* TODO: Add vibration when popup changes * TODO: Add vibration when popup changes
* TODO: Improve support for variably sized items (Re-back with library fast scroller?)
*/ */
class FastScrollRecyclerView class FastScrollRecyclerView
@JvmOverloads @JvmOverloads

View file

@ -92,7 +92,6 @@ abstract class MaterialDragCallback : ItemTouchHelper.Callback() {
// Hook drag events to "lifting" the item (i.e raising it's elevation). Make sure // Hook drag events to "lifting" the item (i.e raising it's elevation). Make sure
// this is only done once when the item is initially picked up. // this is only done once when the item is initially picked up.
// TODO: I think this is possible to improve with a raw ValueAnimator.
if (shouldLift && isCurrentlyActive && actionState == ItemTouchHelper.ACTION_STATE_DRAG) { if (shouldLift && isCurrentlyActive && actionState == ItemTouchHelper.ACTION_STATE_DRAG) {
L.d("Lifting ViewHolder") L.d("Lifting ViewHolder")

View file

@ -344,7 +344,6 @@ constructor(
throw e throw e
} catch (e: Exception) { } catch (e: Exception) {
// Music loading process failed due to something we have not handled. // Music loading process failed due to something we have not handled.
// TODO: Still want to display this error eventually
L.e("Music indexing failed") L.e("Music indexing failed")
L.e(e.stackTraceToString()) L.e(e.stackTraceToString())
emitIndexingCompletion(e) emitIndexingCompletion(e)
@ -392,6 +391,10 @@ constructor(
synchronized(this) { synchronized(this) {
// It's possible that this reload might have changed nothing, so make sure that // It's possible that this reload might have changed nothing, so make sure that
// hasn't happened before dispatching a change to all consumers. // hasn't happened before dispatching a change to all consumers.
// This is an old compat shim back when device library and user library were different
// thinks. For the sake of avoiding drastic changes, it sticks around.
// TODO: Remove this once you start work on kindred.
deviceLibraryChanged = deviceLibraryChanged =
this.library?.songs != newLibrary.songs || this.library?.songs != newLibrary.songs ||
this.library?.albums != newLibrary.albums || this.library?.albums != newLibrary.albums ||