all: update todos

app/src/main/java/org/oxycblt/auxio/MainFragment.kt

@@ -404,9 +404,6 @@ class MainFragment :
     }
 
     private fun updateIndexerState(state: IndexingState?) {
-        // TODO: Make music loading experience a bit more pleasant
-        //  1. Loading placeholder for item lists
-        //  2. Rework the "No Music" case to not be an error and instead result in a placeholder
         if (state is IndexingState.Completed && state.error == null) {
             L.d("Received ok response")
             val binding = requireBinding()

app/src/main/java/org/oxycblt/auxio/home/HomeFragment.kt

@@ -313,9 +313,8 @@ class HomeFragment :
     }
 
     private fun updateIndexerState(state: IndexingState?) {
-        // TODO: Make music loading experience a bit more pleasant
-        //  1. Loading placeholder for item lists
-        //  2. Rework the "No Music" case to not be an error and instead result in a placeholder
+        // TODO: Reduce intrusiveness of current loading state:
+        //  1. "Dry" loads
         val binding = requireBinding()
         when (state) {
             is IndexingState.Completed -> setupCompleteState(binding, state.error)

app/src/main/java/org/oxycblt/auxio/list/recycler/FastScrollRecyclerView.kt

@@ -66,7 +66,6 @@ import org.oxycblt.auxio.util.systemBarInsetsCompat
  * @author Hai Zhang, Alexander Capehart (OxygenCobalt)
  *
  * TODO: Add vibration when popup changes
- * TODO: Improve support for variably sized items (Re-back with library fast scroller?)
  */
 class FastScrollRecyclerView
 @JvmOverloads

app/src/main/java/org/oxycblt/auxio/list/recycler/MaterialDragCallback.kt

@@ -92,7 +92,6 @@ abstract class MaterialDragCallback : ItemTouchHelper.Callback() {
 
         // Hook drag events to "lifting" the item (i.e raising it's elevation). Make sure
         // this is only done once when the item is initially picked up.
-        // TODO: I think this is possible to improve with a raw ValueAnimator.
         if (shouldLift && isCurrentlyActive && actionState == ItemTouchHelper.ACTION_STATE_DRAG) {
             L.d("Lifting ViewHolder")
 

app/src/main/java/org/oxycblt/auxio/music/MusicRepository.kt

@@ -344,7 +344,6 @@ constructor(
             throw e
         } catch (e: Exception) {
             // Music loading process failed due to something we have not handled.
-            // TODO: Still want to display this error eventually
             L.e("Music indexing failed")
             L.e(e.stackTraceToString())
             emitIndexingCompletion(e)
@@ -392,6 +391,10 @@ constructor(
         synchronized(this) {
             // It's possible that this reload might have changed nothing, so make sure that
             // hasn't happened before dispatching a change to all consumers.
+
+            // This is an old compat shim back when device library and user library were different
+            // thinks. For the sake of avoiding drastic changes, it sticks around.
+            // TODO: Remove this once you start work on kindred.
             deviceLibraryChanged =
                 this.library?.songs != newLibrary.songs ||
                     this.library?.albums != newLibrary.albums ||