From b0af681390957584c66629bbb415136761dd54a7 Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Mon, 21 Oct 2024 09:46:43 -0600 Subject: [PATCH] playback: fix broken stateholder lifecycle - Broken ReplayGain setup - Wasn't releasing playback settings --- .../auxio/playback/service/ExoPlaybackStateHolder.kt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/oxycblt/auxio/playback/service/ExoPlaybackStateHolder.kt b/app/src/main/java/org/oxycblt/auxio/playback/service/ExoPlaybackStateHolder.kt index 2947052c2..95dd0ae73 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/service/ExoPlaybackStateHolder.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/service/ExoPlaybackStateHolder.kt @@ -88,20 +88,22 @@ class ExoPlaybackStateHolder( private set fun attach() { - imageSettings.registerListener(this) - player.addListener(this) playbackManager.registerStateHolder(this) - playbackSettings.registerListener(this) musicRepository.addUpdateListener(this) + player.addListener(this) + replayGainProcessor.attach() + playbackSettings.registerListener(this) + imageSettings.registerListener(this) } fun release() { saveJob.cancel() - player.removeListener(this) playbackManager.unregisterStateHolder(this) musicRepository.removeUpdateListener(this) + player.removeListener(this) replayGainProcessor.release() imageSettings.unregisterListener(this) + playbackSettings.unregisterListener(this) player.release() }