From dc2157904ac305b93340f78fab1ae4902dbee966 Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Fri, 11 Jun 2021 08:13:52 -0600 Subject: [PATCH] styles: refactor styles Completely refactor styles once again to improve resource sharing and styling maintainability. --- .../org/oxycblt/auxio/songs/SongsFragment.kt | 2 +- .../layout-land/fragment_compact_playback.xml | 42 +-- .../res/layout-land/fragment_playback.xml | 42 +-- .../res/layout-land/item_album_header.xml | 3 +- .../res/layout-land/item_artist_header.xml | 3 +- .../res/layout-land/item_genre_header.xml | 3 +- .../res/layout-large/item_album_header.xml | 3 +- .../res/layout-large/item_artist_header.xml | 3 +- .../res/layout-large/item_genre_header.xml | 3 +- .../layout-xlarge-land/fragment_playback.xml | 43 +-- .../res/layout-xlarge/fragment_playback.xml | 41 +-- app/src/main/res/layout/activity_main.xml | 3 +- app/src/main/res/layout/dialog_accent.xml | 3 +- app/src/main/res/layout/dialog_blacklist.xml | 3 +- app/src/main/res/layout/fragment_about.xml | 53 +--- .../res/layout/fragment_compact_playback.xml | 37 +-- app/src/main/res/layout/fragment_detail.xml | 4 +- app/src/main/res/layout/fragment_library.xml | 2 - app/src/main/res/layout/fragment_loading.xml | 16 +- app/src/main/res/layout/fragment_playback.xml | 47 +--- app/src/main/res/layout/fragment_queue.xml | 4 +- app/src/main/res/layout/fragment_search.xml | 2 +- app/src/main/res/layout/fragment_settings.xml | 2 - app/src/main/res/layout/fragment_songs.xml | 2 - app/src/main/res/layout/item_album_header.xml | 3 +- .../main/res/layout/item_artist_header.xml | 3 +- app/src/main/res/layout/item_genre_header.xml | 3 +- .../{styles.xml => styles_component.xml} | 0 .../{styles.xml => styles_core.xml} | 0 .../{styles.xml => styles_core.xml} | 0 app/src/main/res/values/styles.xml | 265 ------------------ app/src/main/res/values/styles_android.xml | 64 +++++ app/src/main/res/values/styles_component.xml | 173 ++++++++++++ app/src/main/res/values/styles_core.xml | 39 +++ app/src/main/res/values/styles_ui.xml | 102 +++++++ 35 files changed, 445 insertions(+), 573 deletions(-) rename app/src/main/res/values-large/{styles.xml => styles_component.xml} (100%) rename app/src/main/res/values-night-v27/{styles.xml => styles_core.xml} (100%) rename app/src/main/res/values-v27/{styles.xml => styles_core.xml} (100%) delete mode 100644 app/src/main/res/values/styles.xml create mode 100644 app/src/main/res/values/styles_android.xml create mode 100644 app/src/main/res/values/styles_component.xml create mode 100644 app/src/main/res/values/styles_core.xml create mode 100644 app/src/main/res/values/styles_ui.xml diff --git a/app/src/main/java/org/oxycblt/auxio/songs/SongsFragment.kt b/app/src/main/java/org/oxycblt/auxio/songs/SongsFragment.kt index c84c6a138..c0ae625de 100644 --- a/app/src/main/java/org/oxycblt/auxio/songs/SongsFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/songs/SongsFragment.kt @@ -71,7 +71,7 @@ class SongsFragment : Fragment() { * semantics when it comes to articles. */ private val String.first: Char get() { - // If the name actually starts with "The" or "A", get the character *after* that word. + // If the name actually starts with "The"/"A"/"An", get the character *after* that word. // Yes, this is stupidly english centric but it wont run with other languages. if (length > 5 && startsWith("the ", true)) { return get(4).uppercaseChar() diff --git a/app/src/main/res/layout-land/fragment_compact_playback.xml b/app/src/main/res/layout-land/fragment_compact_playback.xml index 79d25815d..f993ef49e 100644 --- a/app/src/main/res/layout-land/fragment_compact_playback.xml +++ b/app/src/main/res/layout-land/fragment_compact_playback.xml @@ -26,31 +26,18 @@ diff --git a/app/src/main/res/layout-land/fragment_playback.xml b/app/src/main/res/layout-land/fragment_playback.xml index eb536b73c..3ef26d1a2 100644 --- a/app/src/main/res/layout-land/fragment_playback.xml +++ b/app/src/main/res/layout-land/fragment_playback.xml @@ -29,21 +29,18 @@ + app:navGraph="@navigation/nav_main" + tools:layout="@layout/fragment_main" /> \ No newline at end of file diff --git a/app/src/main/res/layout/dialog_accent.xml b/app/src/main/res/layout/dialog_accent.xml index 2ca02c53f..eb9cf294f 100644 --- a/app/src/main/res/layout/dialog_accent.xml +++ b/app/src/main/res/layout/dialog_accent.xml @@ -7,9 +7,8 @@ android:id="@+id/accent_recycler" android:layout_width="match_parent" android:layout_height="match_parent" - android:foregroundGravity="center" android:overScrollMode="never" - android:paddingTop="@dimen/spacing_medium" + android:paddingTop="@dimen/spacing_small" app:layoutManager="org.oxycblt.auxio.settings.accent.AutoGridLayoutManager" app:layout_constraintBottom_toTopOf="@+id/accent_cancel" app:layout_constraintTop_toBottomOf="@+id/accent_header" diff --git a/app/src/main/res/layout/dialog_blacklist.xml b/app/src/main/res/layout/dialog_blacklist.xml index 5354944b9..afeba3541 100644 --- a/app/src/main/res/layout/dialog_blacklist.xml +++ b/app/src/main/res/layout/dialog_blacklist.xml @@ -3,13 +3,12 @@ xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools"> - + tools:text="16.16.16" /> + style="@style/Toolbar.Style.Icon" /> diff --git a/app/src/main/res/layout/fragment_library.xml b/app/src/main/res/layout/fragment_library.xml index 6fa5e9023..0815df1c9 100644 --- a/app/src/main/res/layout/fragment_library.xml +++ b/app/src/main/res/layout/fragment_library.xml @@ -13,8 +13,6 @@ diff --git a/app/src/main/res/layout/fragment_loading.xml b/app/src/main/res/layout/fragment_loading.xml index 54cdde730..b3b5fdec4 100644 --- a/app/src/main/res/layout/fragment_loading.xml +++ b/app/src/main/res/layout/fragment_loading.xml @@ -22,8 +22,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_margin="@dimen/spacing_small" - android:indeterminateTint="?attr/colorPrimary" - android:indeterminateTintMode="src_in" android:paddingBottom="@dimen/spacing_tiny" /> @@ -50,25 +46,17 @@