Fabio/Auxio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

detail: fix broken album menu

Browse source 
Fix broken menu items in the album detail view.

No idea why this happened. Probably a mistake while I was redoing the
menus previously.
This commit is contained in:
OxygenCobalt 2022-06-24 09:07:18 -06:00
parent 149da883fe
commit efd24a4fee
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
6 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/org/oxycblt/auxio/detail/AlbumDetailFragment.kt
View file

@ -113,7 +113,7 @@ class AlbumDetailFragment :
true true
} }
R.id.action_go_artist -> { R.id.action_go_artist -> {
navModel.exploreNavigateTo(unlikelyToBeNull(detailModel.currentAlbum.value)) navModel.exploreNavigateTo(unlikelyToBeNull(detailModel.currentAlbum.value).artist)
true true
} }
else -> false else -> false

2
app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackStateManager.kt
View file

@ -45,8 +45,6 @@ import org.oxycblt.auxio.util.logW
* *
* All access should be done with [PlaybackStateManager.getInstance]. * All access should be done with [PlaybackStateManager.getInstance].
* @author OxygenCobalt * @author OxygenCobalt
*
* TODO: Bug test app behavior when playback stops
*/ */
class PlaybackStateManager private constructor() { class PlaybackStateManager private constructor() {
private val musicStore = MusicStore.getInstance() private val musicStore = MusicStore.getInstance()

2
app/src/main/java/org/oxycblt/auxio/ui/BottomSheetLayout.kt
View file

@ -77,6 +77,8 @@ import org.oxycblt.auxio.util.stateList
* @author OxygenCobalt (With help from Umano and Hai Zhang) * @author OxygenCobalt (With help from Umano and Hai Zhang)
* *
* TODO: Implement rounded corners on the bar (when rounded covers is enabled) * TODO: Implement rounded corners on the bar (when rounded covers is enabled)
*
* TODO: Fix several issues with a full-collapse event (blocks automatic rescanning)
*/ */
class BottomSheetLayout class BottomSheetLayout
@JvmOverloads @JvmOverloads

4
app/src/main/res/layout-sw600dp/fragment_playback_bar.xml
View file

@ -21,7 +21,7 @@
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="@dimen/spacing_small" android:layout_marginStart="@dimen/spacing_small"
android:layout_marginEnd="@dimen/spacing_small" android:layout_marginEnd="@dimen/spacing_tiny"
app:layout_constraintBottom_toTopOf="@+id/playback_info" app:layout_constraintBottom_toTopOf="@+id/playback_info"
app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper" app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper"
app:layout_constraintStart_toEndOf="@+id/playback_cover" app:layout_constraintStart_toEndOf="@+id/playback_cover"
@ -35,7 +35,7 @@
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="@dimen/spacing_small" android:layout_marginStart="@dimen/spacing_small"
android:layout_marginEnd="@dimen/spacing_small" android:layout_marginEnd="@dimen/spacing_tiny"
android:ellipsize="end" android:ellipsize="end"
app:layout_constraintBottom_toBottomOf="@+id/playback_cover" app:layout_constraintBottom_toBottomOf="@+id/playback_cover"
app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper" app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper"

4
app/src/main/res/layout/fragment_playback_bar.xml
View file

@ -21,7 +21,7 @@
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="@dimen/spacing_small" android:layout_marginStart="@dimen/spacing_small"
android:layout_marginEnd="@dimen/spacing_small" android:layout_marginEnd="@dimen/spacing_tiny"
app:layout_constraintBottom_toTopOf="@+id/playback_info" app:layout_constraintBottom_toTopOf="@+id/playback_info"
app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper" app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper"
app:layout_constraintStart_toEndOf="@+id/playback_cover" app:layout_constraintStart_toEndOf="@+id/playback_cover"
@ -35,7 +35,7 @@
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="@dimen/spacing_small" android:layout_marginStart="@dimen/spacing_small"
android:layout_marginEnd="@dimen/spacing_small" android:layout_marginEnd="@dimen/spacing_tiny"
android:ellipsize="end" android:ellipsize="end"
app:layout_constraintBottom_toBottomOf="@+id/playback_cover" app:layout_constraintBottom_toBottomOf="@+id/playback_cover"
app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper" app:layout_constraintEnd_toStartOf="@+id/playback_controls_wrapper"

3
app/src/main/res/menu/menu_album_detail.xml
View file

@ -9,7 +9,4 @@
<item <item
android:id="@+id/action_go_artist" android:id="@+id/action_go_artist"
android:title="@string/lbl_go_artist" /> android:title="@string/lbl_go_artist" />
<item
android:id="@+id/action_song_detail"
android:title="@string/lbl_song_detail" />
</menu> </menu>