From 6c055dd24c669c4242cb2c6e75922f963cff8971 Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Thu, 27 Feb 2025 01:16:00 +0100 Subject: [PATCH] driver: screenshot fixes --- lib/widgets/debug/app_debug_page.dart | 1 + scripts/screenshot_post_process.sh | 10 +++++----- test_driver/driver_screenshots_test.dart | 1 + 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/widgets/debug/app_debug_page.dart b/lib/widgets/debug/app_debug_page.dart index bc840d801..f124ce6ae 100644 --- a/lib/widgets/debug/app_debug_page.dart +++ b/lib/widgets/debug/app_debug_page.dart @@ -110,6 +110,7 @@ class AppDebugPage extends StatelessWidget { case AppDebugAction.prepScreenshotCountries: settings.changeFilterVisibility({ LocationFilter(LocationLevel.country, 'Belgium;BE'), + LocationFilter(LocationLevel.country, 'Croatia;HR'), }, false); case AppDebugAction.mediaStoreScanDir: // scan files copied from test assets diff --git a/scripts/screenshot_post_process.sh b/scripts/screenshot_post_process.sh index 1245d9995..9fcb610c5 100755 --- a/scripts/screenshot_post_process.sh +++ b/scripts/screenshot_post_process.sh @@ -10,16 +10,16 @@ fi # expects: # - ImageMagick 6 -# - raw screenshots sized at 1080x2280 in `/screenshots/raw` +# - raw screenshots sized at 1080x2520 (21∶9) in `/screenshots/raw` -DEVICE_OVERLAY_LTR=~/code/aves_extra/screenshots/device_overlay_s10e_ltr_nav_gestures.png -DEVICE_FRAME=~/code/aves_extra/screenshots/device_frame_s10e.png +DEVICE_OVERLAY_LTR=~/code/aves_extra/screenshots/device_overlay_ltr_nav_gestures.png +DEVICE_FRAME=~/code/aves_extra/screenshots/device_frame_1142x2650_for_1080x2520.png # FRAME_SIZE: dimensions of DEVICE_FRAME -FRAME_SIZE=1142x2410 +FRAME_SIZE=1142x2650 # FRAME_OFFSET: offset for content in DEVICE_FRAME FRAME_OFFSET=31x53 # PLAY_SIZE: contain FRAME_SIZE in 9:16 -PLAY_SIZE=1356x2410 +PLAY_SIZE=1490x2650 cd screenshots || exit diff --git a/test_driver/driver_screenshots_test.dart b/test_driver/driver_screenshots_test.dart index a71863f43..0a58dd0a9 100644 --- a/test_driver/driver_screenshots_test.dart +++ b/test_driver/driver_screenshots_test.dart @@ -160,6 +160,7 @@ void info() { await driver.scrollY(verticalPageView, -600); await _selectMapStyle('googleNormal'); + await Future.delayed(const Duration(seconds: 1)); await _takeScreenshot(driver, '3');