From 81a2b84c9f4204a5a08698bcd75347bbdca10c0b Mon Sep 17 00:00:00 2001
From: Thibault Deckers <thibault.deckers@gmail.com>
Date: Fri, 30 May 2025 18:03:29 +0200
Subject: [PATCH] app bar layout padding review

---
 lib/widgets/collection/filter_bar.dart       | 5 +++--
 lib/widgets/common/app_bar/crumb_line.dart   | 4 +++-
 lib/widgets/explorer/app_bar.dart            | 3 ++-
 lib/widgets/filter_grids/common/app_bar.dart | 3 ++-
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/lib/widgets/collection/filter_bar.dart b/lib/widgets/collection/filter_bar.dart
index a88ff1be9..b565d7bc6 100644
--- a/lib/widgets/collection/filter_bar.dart
+++ b/lib/widgets/collection/filter_bar.dart
@@ -9,8 +9,8 @@ import 'package:provider/provider.dart';
 class FilterBar extends StatefulWidget {
   static const EdgeInsets chipPadding = EdgeInsets.symmetric(horizontal: 4);
   static const EdgeInsets rowPadding = EdgeInsets.symmetric(horizontal: 4);
-  static const double verticalPadding = 16;
-  static const double preferredHeight = AvesFilterChip.minChipHeight + verticalPadding;
+  static const EdgeInsets padding = EdgeInsets.only(top: 4, bottom: 8);
+  static final double preferredHeight = AvesFilterChip.minChipHeight + padding.vertical;
 
   final List<CollectionFilter> filters;
   final bool interactive;
@@ -84,6 +84,7 @@ class _FilterBarState extends State<FilterBar> {
     return Container(
       // specify transparent as a workaround to prevent
       // chip border clipping when the floating app bar is fading
+      padding: FilterBar.padding,
       color: Colors.transparent,
       height: FilterBar.preferredHeight,
       child: AnimatedList(
diff --git a/lib/widgets/common/app_bar/crumb_line.dart b/lib/widgets/common/app_bar/crumb_line.dart
index 4ad8e3414..580f1ecd0 100644
--- a/lib/widgets/common/app_bar/crumb_line.dart
+++ b/lib/widgets/common/app_bar/crumb_line.dart
@@ -8,6 +8,8 @@ class CrumbLine<T> extends StatefulWidget {
   final T Function(BuildContext context, int index) combine;
   final void Function(T combined) onTap;
 
+  static const EdgeInsets padding = EdgeInsets.only(top: 6, bottom: 20);
+
   const CrumbLine({
     super.key,
     required this.split,
@@ -18,7 +20,7 @@ class CrumbLine<T> extends StatefulWidget {
   @override
   State<CrumbLine<T>> createState() => _CrumbLineState<T>();
 
-  static double getPreferredHeight(TextScaler textScaler) => textScaler.scale(kToolbarHeight);
+  static double getPreferredHeight(TextScaler textScaler) => textScaler.scale(22) + padding.vertical;
 }
 
 class _CrumbLineState<T> extends State<CrumbLine<T>> {
diff --git a/lib/widgets/explorer/app_bar.dart b/lib/widgets/explorer/app_bar.dart
index 7ee7e14a5..dc43f661f 100644
--- a/lib/widgets/explorer/app_bar.dart
+++ b/lib/widgets/explorer/app_bar.dart
@@ -65,7 +65,8 @@ class _ExplorerAppBarState extends State<ExplorerAppBar> with WidgetsBindingObse
       actions: _buildActions,
       bottom: LayoutBuilder(
         builder: (context, constraints) {
-          return SizedBox(
+          return Container(
+            padding: CrumbLine.padding,
             width: constraints.maxWidth,
             height: CrumbLine.getPreferredHeight(MediaQuery.textScalerOf(context)),
             child: ValueListenableBuilder<VolumeRelativeDirectory?>(
diff --git a/lib/widgets/filter_grids/common/app_bar.dart b/lib/widgets/filter_grids/common/app_bar.dart
index b24a5380f..680ab82bc 100644
--- a/lib/widgets/filter_grids/common/app_bar.dart
+++ b/lib/widgets/filter_grids/common/app_bar.dart
@@ -170,7 +170,8 @@ class _FilterGridAppBarState<T extends CollectionFilter, CSAD extends ChipSetAct
                 if (_showGroupCrumbLine(context))
                   LayoutBuilder(
                     builder: (context, constraints) {
-                      return SizedBox(
+                      return Container(
+                        padding: CrumbLine.padding,
                         width: constraints.maxWidth,
                         height: CrumbLine.getPreferredHeight(MediaQuery.textScalerOf(context)),
                         child: Selector<FilterGroupNotifier, Uri?>(