Fabio/aves
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#396 fixed inline writing MP4 on API <29

Browse source
This commit is contained in:
Thibault Deckers 2022-11-11 21:43:09 +01:00
parent 38b54ecd64
commit bb758cdb34
3 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
android/app/src/main/kotlin/deckers/thibault/aves/model/provider/ImageProvider.kt
View file

@ -597,8 +597,10 @@ abstract class ImageProvider {
mimeType = mimeType, mimeType = mimeType,
uri = uri, uri = uri,
path = path, path = path,
// do not truncate // do not truncate with "t"
mode = "w", // "w" is enough on API 29+, but it will yield an empty file on API <29
// so "r" is necessary for backward compatibility
mode = "rw",
) ?: throw Exception("failed to open file descriptor for uri=$uri path=$path") ) ?: throw Exception("failed to open file descriptor for uri=$uri path=$path")
pfd.use { pfd.use {
FileOutputStream(it.fileDescriptor).use { outputStream -> FileOutputStream(it.fileDescriptor).use { outputStream ->

2
lib/model/entry.dart
View file

@ -748,7 +748,7 @@ class AvesEntry {
bool get isBurst => burstEntries?.isNotEmpty == true; bool get isBurst => burstEntries?.isNotEmpty == true;
// for backwards compatibility // for backward compatibility
bool get _isMotionPhotoLegacy => isMultiPage && !isBurst && mimeType == MimeTypes.jpeg; bool get _isMotionPhotoLegacy => isMultiPage && !isBurst && mimeType == MimeTypes.jpeg;
bool get isMotionPhoto => (_catalogMetadata?.isMotionPhoto ?? false) || _isMotionPhotoLegacy; bool get isMotionPhoto => (_catalogMetadata?.isMotionPhoto ?? false) || _isMotionPhotoLegacy;

2
lib/widgets/settings/settings_page.dart
View file

@ -182,7 +182,7 @@ class _SettingsPageState extends State<SettingsPage> with FeedbackMixin {
final version = allJsonMap[exportVersionKey]; final version = allJsonMap[exportVersionKey];
final importable = <AppExportItem, dynamic>{}; final importable = <AppExportItem, dynamic>{};
if (version == null) { if (version == null) {
// backwards compatibility before versioning // backward compatibility before versioning
importable[AppExportItem.settings] = allJsonMap; importable[AppExportItem.settings] = allJsonMap;
} else { } else {
if (allJsonMap is! Map) { if (allJsonMap is! Map) {