Fabio/brouter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Enable PMD rule LogicInversion and fix violations

Browse source
This commit is contained in:
Manuel Fuhr 2022-11-13 16:10:19 +01:00
parent 41d25cd523
commit 49295eb850
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
brouter-util/src/main/java/btools/util/BitCoderContext.java
View file

@ -309,12 +309,12 @@ public class BitCoderContext {
for (int i = 0; i < 31; i++) { for (int i = 0; i < 31; i++) {
int value = ctx.decodeVarBits(); int value = ctx.decodeVarBits();
int v0 = (1 << i) + 3; int v0 = (1 << i) + 3;
if (!(v0 == value)) if (v0 != value)
throw new RuntimeException("value mismatch value=" + value + "v0=" + v0); throw new RuntimeException("value mismatch value=" + value + "v0=" + v0);
} }
for (int i = 0; i < 100000; i += 13) { for (int i = 0; i < 100000; i += 13) {
int value = ctx.decodeVarBits(); int value = ctx.decodeVarBits();
if (!(value == i)) if (value != i)
throw new RuntimeException("value mismatch i=" + i + "v=" + value); throw new RuntimeException("value mismatch i=" + i + "v=" + value);
} }
} }

1
config/pmd/pmd-ruleset.xml
View file

@ -24,7 +24,6 @@
<exclude name="EmptyControlStatement" /> <exclude name="EmptyControlStatement" />
<exclude name="ForLoopCanBeForeach" /> <exclude name="ForLoopCanBeForeach" />
<exclude name="LiteralsFirstInComparisons" /> <exclude name="LiteralsFirstInComparisons" />
<exclude name="LogicInversion" />
<exclude name="MissingOverride" /> <exclude name="MissingOverride" />
<exclude name="OneDeclarationPerLine" /> <exclude name="OneDeclarationPerLine" />
<exclude name="OverrideBothEqualsAndHashcode" /> <exclude name="OverrideBothEqualsAndHashcode" />