From 82d28ed08ac7d8d39e1499c2d61abfaf2580e4b0 Mon Sep 17 00:00:00 2001 From: Manuel Fuhr Date: Fri, 31 Dec 2021 08:30:37 +0100 Subject: [PATCH] Fix build with empty signing environment variables GitHub action secrets default to empty values if they aren't defined in a repository. Any fork of the repo doesn't have access to the secrets and the jobs therefore fail. --- brouter-routing-app/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/brouter-routing-app/build.gradle b/brouter-routing-app/build.gradle index 58dde91..9ddfdb3 100644 --- a/brouter-routing-app/build.gradle +++ b/brouter-routing-app/build.gradle @@ -21,7 +21,7 @@ android { sourceSets.main.assets.srcDirs += new File(project.buildDir, 'assets') - if(project.hasProperty("RELEASE_STORE_FILE")) { + if(project.hasProperty("RELEASE_STORE_FILE") && RELEASE_STORE_FILE.length() > 0) { signingConfigs { // this uses a file ~/.gradle/gradle.properties // with content: @@ -49,7 +49,7 @@ android { release { minifyEnabled false debuggable false - if(project.hasProperty("RELEASE_STORE_FILE")) { + if(project.hasProperty("RELEASE_STORE_FILE") && RELEASE_STORE_FILE.length() > 0) { signingConfig signingConfigs.release } proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'