Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Deprecate 'builtinweb' 'he' for 'he.net' for consistency with protocol

Browse source
This commit is contained in:
Indrajit Raychaudhuri 2024-07-12 16:48:40 -05:00 committed by Richard Hansen
parent ecf935a4e2
commit 0973e9d83c
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog.md
View file

@ -19,6 +19,11 @@ repository history](https://github.com/ddclient/ddclient/commits/master).
`Digest::SHA` is now required. Previously, `Digest::SHA1` was used (if
available) as an alternative to `Digest::SHA`.
[#685](https://github.com/ddclient/ddclient/pull/685)
* The `he` built-in web IP discovery service (`--webv4=he`, `--webv6=he`, and
`--web=he`) was renamed to `he.net` for consistency with the new `he.net`
protocol. The old name is still accepted but is deprecated and will be
removed in a future version of ddclient.
[#682](https://github.com/ddclient/ddclient/pull/682)
### New features

4
ddclient.in
View file

@ -195,6 +195,7 @@ our %builtinweb = (
'freedns' => {'url' => 'https://freedns.afraid.org/dynamic/check.php'},
'googledomains' => {'url' => 'https://domains.google.com/checkip'}, # Deprecated! See https://github.com/ddclient/ddclient/issues/622 for more details
'he' => {'url' => 'https://checkip.dns.he.net/'},
'he.net' => {'url' => 'https://checkip.dns.he.net/'},
'ip4only.me' => {'url' => 'https://ip4only.me/api/'},
'ip6only.me' => {'url' => 'https://ip6only.me/api/'},
'ipify-ipv4' => {'url' => 'https://api.ipify.org/'},
@ -2913,6 +2914,7 @@ sub get_ip {
$skip = opt('web-skip', $h);
if (exists $builtinweb{$url}) {
warning("googledomains is deprecated! See https://github.com/ddclient/ddclient/issues/622 for more info.") if ($url eq 'googledomains');
warning("'he' is deprecated; use 'he.net' instead.") if ($url eq 'he');
$skip //= $builtinweb{$url}->{'skip'};
$url = $builtinweb{$url}->{'url'};
}
@ -3308,6 +3310,7 @@ sub get_ipv4 {
$skip = opt('webv4-skip', $h);
if (exists $builtinweb{$url}) {
warning("googledomains is deprecated! See https://github.com/ddclient/ddclient/issues/622 for more info.") if ($url eq 'googledomains');
warning("'he' is deprecated; use 'he.net' instead.") if ($url eq 'he');
$skip //= $builtinweb{$url}->{'skip'};
$url = $builtinweb{$url}->{'url'};
$arg = $url;
@ -3425,6 +3428,7 @@ sub get_ipv6 {
$skip = opt('webv6-skip', $h);
if (exists $builtinweb{$url}) {
warning("googledomains is deprecated! See https://github.com/ddclient/ddclient/issues/622 for more info.") if ($url eq 'googledomains');
warning("'he' is deprecated; use 'he.net' instead.") if ($url eq 'he');
$skip //= $builtinweb{$url}->{'skip'};
$url = $builtinweb{$url}->{'url'};
$arg = $url;