Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dyndns2: Expand rationale for not checking returned IP

Browse source
This commit is contained in:
Richard Hansen 2024-07-17 22:52:33 -04:00
parent 9256096e64
commit 23dad564be
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ddclient.in
View file

@ -4129,8 +4129,11 @@ sub nic_dyndns2_update {
failed("updating %s: Could not connect to %s.", $hosts, $groupcfg{'server'}); failed("updating %s: Could not connect to %s.", $hosts, $groupcfg{'server'});
next; next;
} }
# The IP address normally comes after the status, but we ignore it. (Some services do not # The IP address normally comes after the status, but we ignore it. We could compare it
# return the IP so we can't rely on it anyway.) # with the expected address and mark the update as failed if it differs, but (1) some
# services do not return the IP; and (2) comparison is brittle (e.g., 192.000.002.001
# vs. 192.0.2.1) and false errors could cause high load on the service (an update attempt
# every min-error-interval instead of every max-interval).
(my $status = $line) =~ s/ .*$//; (my $status = $line) =~ s/ .*$//;
if ($status eq 'nochg') { if ($status eq 'nochg') {
warning("updating %s: %s: %s", $hosts, $status, $errors{$status}); warning("updating %s: %s: %s", $hosts, $status, $errors{$status});