From 38a4e9eeef4916fdfd14974f0d896668650db1bd Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Fri, 26 Jul 2024 17:23:21 -0400
Subject: [PATCH] nic_updateable: Remove unnecessary `force_update` parameter

`nic_updateable` can look up the host's `force_update` function itself
so there's no need to pass it as an argument.
---
 ddclient.in | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/ddclient.in b/ddclient.in
index dc2daab..5c73b46 100755
--- a/ddclient.in
+++ b/ddclient.in
@@ -1366,7 +1366,6 @@ sub update_nics {
 
     for my $p (sort keys %protocols) {
         my (@hosts, %ipsv4, %ipsv6) = ();
-        my $force_update = $protocols{$p}{'force_update'};
         my $update = $protocols{$p}{'update'};
 
         for my $h (sort keys %config) {
@@ -1461,7 +1460,7 @@ sub update_nics {
                 next;
             }
 
-            next if !nic_updateable($h, $force_update);
+            next if !nic_updateable($h);
             push @hosts, $h;
 
             $ipsv4{$ipv4} = $h if ($ipv4);
@@ -3527,8 +3526,8 @@ EoEXAMPLE
 ## Returns true if we can go ahead and update the IP address at server
 ######################################################################
 sub nic_updateable {
-    my $host   = shift;
-    my $sub    = shift;
+    my ($host) = @_;
+    my $force_update = $protocols{$config{$host}{protocol}}{force_update};
     my $update = 0;
     my $ip     = $config{$host}{'wantip'};
     my $ipv4   = $config{$host}{'wantipv4'};
@@ -3708,7 +3707,7 @@ sub nic_updateable {
             $update = 1;
         }
 
-    } elsif (defined($sub) && &$sub($host)) {
+    } elsif (defined($force_update) && $force_update->($host)) {
         $update = 1;
     } elsif ((defined($recap{$host}{'static'}) && defined($config{$host}{'static'}) &&
               ($recap{$host}{'static'} ne $config{$host}{'static'})) ||