From 435357ac500ba8e725c58cd940fb144a50f5ab22 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Fri, 19 Jul 2024 19:39:00 -0400 Subject: [PATCH] easydns: Invert condition to improve readability --- ddclient.in | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/ddclient.in b/ddclient.in index c441be4..7b34fbb 100755 --- a/ddclient.in +++ b/ddclient.in @@ -4823,15 +4823,17 @@ sub nic_easydns_update { }; my ($status) = $body =~ qr/^(\S*)\b/; $config{$h}{"status-ipv$ipv"} = $status; - if ($status eq 'NOERROR') { - $config{$h}{"ipv$ipv"} = $ip; - $config{$h}{'mtime'} = $now; - success("$h: IPv$ipv address set to $ip"); - } elsif (exists $errors{$status}) { - failed("$h: $status: $errors{$status}"); - } else { - failed("$h: unexpected result: $body"); + if ($status ne 'NOERROR') { + if (exists $errors{$status}) { + failed("$h: $status: $errors{$status}"); + } else { + failed("$h: unexpected result: $body"); + } + next; } + $config{$h}{"ipv$ipv"} = $ip; + $config{$h}{'mtime'} = $now; + success("$h: IPv$ipv address set to $ip"); } } }