Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

zoneedit1: Add TODO comments for problematic bits of code

Browse source
This commit is contained in:
Richard Hansen 2024-07-12 18:28:27 -04:00
parent 217bc998fc
commit 5db77f7c31
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ddclient.in
View file

@ -4662,6 +4662,8 @@ sub nic_zoneedit1_update {
next if !header_ok($hosts, $reply); next if !header_ok($hosts, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
# TODO: This is awkward and fragile -- it assumes that each line in the response body
# corresponds with each host in @hosts (and in the same order).
for my $line (@reply) { for my $line (@reply) {
if ($h && $line =~ /^[^<]*<(SUCCESS|ERROR)\s+([^>]+)>(.*)/) { if ($h && $line =~ /^[^<]*<(SUCCESS|ERROR)\s+([^>]+)>(.*)/) {
my ($status, $assignments, $rest) = ($1, $2, $3); my ($status, $assignments, $rest) = ($1, $2, $3);
@ -4692,6 +4694,7 @@ sub nic_zoneedit1_update {
redo if $line; redo if $line;
} }
} }
# TODO: Shouldn't this log join(',' @hosts) instead of $hosts?
failed("updating %s: no response from %s", $hosts, $config{$h}{'server'}) failed("updating %s: no response from %s", $hosts, $config{$h}{'server'})
if @hosts; if @hosts;
} }