From 6fbb7eb3dc55608e38dacf2181e21f85ab9fae19 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Sat, 13 Jul 2024 18:10:59 -0400 Subject: [PATCH] domeneshop: Honor `http:` or `https:` scheme in `server` variable --- ChangeLog.md | 6 +++--- ddclient.in | 9 +-------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index fe98389..cc2e604 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -62,9 +62,9 @@ repository history](https://github.com/ddclient/ddclient/commits/master). address changes. [#654](https://github.com/ddclient/ddclient/pull/654) * `he.net`: Added support for updating Hurricane Electric records. [#682](https://github.com/ddclient/ddclient/pull/682) - * `dyndns2`: The `server` option can now include `http://` or `https://` to - control the use of TLS. If omitted, the value of the `ssl` option is used - to determine the scheme. + * `dyndns2`, `domeneshop`: The `server` option can now include `http://` or + `https://` to control the use of TLS. If omitted, the value of the `ssl` + option is used to determine the scheme. [#703](https://github.com/ddclient/ddclient/pull/703) ### Bug fixes diff --git a/ddclient.in b/ddclient.in index 89f40f7..d2f149b 100755 --- a/ddclient.in +++ b/ddclient.in @@ -4570,16 +4570,9 @@ sub nic_domeneshop_update { my $ip = delete $config{$h}{'wantip'}; info("Setting IP address to %s for %s", $ip, $h); verbose("UPDATE:", "Updating %s", $h); - - # Set the URL that we're going to to update - my $url; - $url = $globals{'ssl'} ? "https://" : "http://"; - $url .= "$config{$h}{'server'}$endpointPath?hostname=$h&myip=$ip"; - - # Try to get URL my $reply = geturl( proxy => opt('proxy'), - url => $url, + url => "$config{$h}{'server'}$endpointPath?hostname=$h&myip=$ip", login => $config{$h}{'login'}, password => $config{$h}{'password'}, );