Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

woima: Honor http: or https: scheme in server variable

Browse source
This commit is contained in:
Richard Hansen 2024-07-13 18:23:01 -04:00
parent 0ed2970852
commit 7754c65103
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog.md
View file

@ -62,9 +62,9 @@ repository history](https://github.com/ddclient/ddclient/commits/master).
address changes. [#654](https://github.com/ddclient/ddclient/pull/654) address changes. [#654](https://github.com/ddclient/ddclient/pull/654)
* `he.net`: Added support for updating Hurricane Electric records. * `he.net`: Added support for updating Hurricane Electric records.
[#682](https://github.com/ddclient/ddclient/pull/682) [#682](https://github.com/ddclient/ddclient/pull/682)
* `dyndns2`, `domeneshop`, `dnsmadeeasy`, `keysystems`: The `server` option * `dyndns2`, `domeneshop`, `dnsmadeeasy`, `keysystems`, `woima`: The `server`
can now include `http://` or `https://` to control the use of TLS. If option can now include `http://` or `https://` to control the use of TLS.
omitted, the value of the `ssl` option is used to determine the scheme. If omitted, the value of the `ssl` option is used to determine the scheme.
[#703](https://github.com/ddclient/ddclient/pull/703) [#703](https://github.com/ddclient/ddclient/pull/703)
### Bug fixes ### Bug fixes

12
ddclient.in
View file

@ -1054,7 +1054,12 @@ our %protocols = (
'custom' => setv(T_BOOL, 0, 1, 0, undef), 'custom' => setv(T_BOOL, 0, 1, 0, undef),
'mx' => setv(T_OFQDN, 0, 1, undef, undef), 'mx' => setv(T_OFQDN, 0, 1, undef, undef),
'script' => setv(T_STRING, 0, 1, '/nic/update', undef), 'script' => setv(T_STRING, 0, 1, '/nic/update', undef),
'server' => setv(T_FQDNP, 0, 0, 'dyn.woima.fi', undef), # As of 2024-07-13, dyn.woima.fi does not have a valid TLS certificate so the `http:`
# scheme is explicitly specified here. Once a proper certificate is deployed, or if
# the user overrides certificate validation, the user can manually set the `server`
# option and either change http: to https: or omit the scheme (in which case ddclient
# will use the value of the `ssl` option to determine the scheme).
'server' => setv(T_FQDNP, 0, 0, 'http://dyn.woima.fi', undef),
'static' => setv(T_BOOL, 0, 1, 0, undef), 'static' => setv(T_BOOL, 0, 1, 0, undef),
'wildcard' => setv(T_BOOL, 0, 1, 0, undef), 'wildcard' => setv(T_BOOL, 0, 1, 0, undef),
}, },
@ -6802,10 +6807,7 @@ sub nic_woima_update {
info("setting IP address to %s for %s", $ip, $h); info("setting IP address to %s for %s", $ip, $h);
verbose("UPDATE:", "updating %s", $h); verbose("UPDATE:", "updating %s", $h);
my $url = "$config{$h}{'server'}$config{$h}{'script'}?system=";
## Select the DynDNS system to update
## TODO: endpoint does not support https with functioning certificate. Remove?
my $url = "http://$config{$h}{'server'}$config{$h}{'script'}?system=";
if ($config{$h}{'custom'}) { if ($config{$h}{'custom'}) {
warning("updating %s: 'custom' and 'static' may not be used together. ('static' ignored)", $h) warning("updating %s: 'custom' and 'static' may not be used together. ('static' ignored)", $h)
if $config{$h}{'static'}; if $config{$h}{'static'};