Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #38 from MichaelHarder/fix-nsupdate-ipv6-record-type

Browse source 
fix nsupdate using wrong type for ipv6 addresses

nsupdate was failing because it was trying to set an A record with an ipv6 address. This will check for an ipv6 address and use the appropriate record type.
This commit is contained in:
wimpunk 2016-02-11 21:07:06 +01:00
commit 7cad3a497f
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ddclient
View file

@ -24,6 +24,7 @@ use strict;
use Getopt::Long; use Getopt::Long;
use Sys::Hostname; use Sys::Hostname;
use IO::Socket; use IO::Socket;
use Data::Validate::IP;
my $version = "3.8.3"; my $version = "3.8.3";
my $programd = $0; my $programd = $0;
@ -4132,6 +4133,12 @@ sub nic_nsupdate_update {
my $server = $config{$h}{'server'}; my $server = $config{$h}{'server'};
my $zone = $config{$h}{'zone'}; my $zone = $config{$h}{'zone'};
my $ip = $config{$h}{'wantip'}; my $ip = $config{$h}{'wantip'};
my $recordtype = '';
if (is_ipv6($ip)) {
$recordtype = 'AAAA';
} else {
$recordtype = 'A';
}
delete $config{$_}{'wantip'} foreach @hosts; delete $config{$_}{'wantip'} foreach @hosts;
info("setting IP address to %s for %s", $ip, $hosts); info("setting IP address to %s for %s", $ip, $hosts);
@ -4144,8 +4151,8 @@ zone $zone.
EoINSTR1 EoINSTR1
foreach (@hosts) { foreach (@hosts) {
$instructions .= <<EoINSTR2; $instructions .= <<EoINSTR2;
update delete $_. A update delete $_. $recordtype
update add $_. $config{$_}{'ttl'} A $ip update add $_. $config{$_}{'ttl'} $recordtype $ip
EoINSTR2 EoINSTR2
} }
$instructions .= <<EoINSTR3; $instructions .= <<EoINSTR3;