Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

header_ok: Only keep first line of argument

Browse source 
This allows callers to pass the entire response without generating
overly long error messages.
This commit is contained in:
Richard Hansen 2024-05-17 21:27:59 -04:00
parent b58a10b3e3
commit adbac91be7
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ddclient.in
View file

@ -3774,6 +3774,7 @@ sub nic_updateable {
###################################################################### ######################################################################
sub header_ok { sub header_ok {
my ($host, $line) = @_; my ($host, $line) = @_;
$line =~ s/\r?\n.*//s;
my $ok = 0; my $ok = 0;
if ($line =~ m%^s*HTTP/.*\s+(\d+)%i) { if ($line =~ m%^s*HTTP/.*\s+(\d+)%i) {

6
t/header_ok.pl
View file

@ -51,6 +51,12 @@ my @test_cases = (
input => 'HTTP/1.1 456 bad', input => 'HTTP/1.1 456 bad',
want => 0, want => 0,
}, },
{
desc => 'only first line is logged on error',
input => "HTTP/1.1 404 not found\n\nbody",
want => 0,
wantmsg => qr/(?!body)/,
},
); );
for my $tc (@test_cases) { for my $tc (@test_cases) {