Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only write the PID file if daemonized

Browse source 
There's not much point in writing a PID file if the user does not want
to fork. (The process executing ddclient already knows the PID, so it
can save it to a file if desired.)

This change is a prerequisite to using Proc::Daemon to fix the buggy
daemonization logic.
This commit is contained in:
Richard Hansen 2020-05-26 20:29:13 -04:00
parent dc37e00d9d
commit b094c1bff5
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ddclient
View file

@ -742,7 +742,7 @@ my @opt = (
[ "protocol", "=s", "-protocol type : update protocol used" ], [ "protocol", "=s", "-protocol type : update protocol used" ],
[ "file", "=s", "-file path : load configuration information from 'path'" ], [ "file", "=s", "-file path : load configuration information from 'path'" ],
[ "cache", "=s", "-cache path : record address used in 'path'" ], [ "cache", "=s", "-cache path : record address used in 'path'" ],
[ "pid", "=s", "-pid path : record process id in 'path'" ], [ "pid", "=s", "-pid path : record process id in 'path' if daemonized" ],
"", "",
[ "use", "=s", "-use which : how the should IP address be obtained." ], [ "use", "=s", "-use which : how the should IP address be obtained." ],
&ip_strategies_usage(), &ip_strategies_usage(),
@ -839,10 +839,6 @@ if (opt('foreground')) {
open(STDOUT, ">/dev/null"); open(STDOUT, ">/dev/null");
open(STDERR, ">/dev/null"); open(STDERR, ">/dev/null");
open(STDIN, "</dev/null"); open(STDIN, "</dev/null");
}
# write out the pid file if we're daemon'ized
if (opt('daemon')) {
write_pid(); write_pid();
} }