domeneshop: Improve log messages

This commit is contained in:
Richard Hansen 2024-07-22 22:07:15 -04:00
parent 231601ae54
commit b4e08ae3ae

View file

@ -4316,8 +4316,7 @@ sub nic_domeneshop_update {
my $endpointPath = "/v0/dyndns/update"; my $endpointPath = "/v0/dyndns/update";
for my $h (@_) { for my $h (@_) {
my $ip = delete $config{$h}{'wantip'}; my $ip = delete $config{$h}{'wantip'};
info("Setting IP address to %s for %s", $ip, $h); info("$h: Setting IP address to $ip");
verbose("UPDATE:", "Updating %s", $h);
my $reply = geturl( my $reply = geturl(
proxy => opt('proxy'), proxy => opt('proxy'),
url => "$config{$h}{'server'}$endpointPath?hostname=$h&myip=$ip", url => "$config{$h}{'server'}$endpointPath?hostname=$h&myip=$ip",
@ -4325,7 +4324,7 @@ sub nic_domeneshop_update {
password => $config{$h}{'password'}, password => $config{$h}{'password'},
); );
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("Updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("$h: Request to $config{$h}{'server'} failed");
next; next;
} }
next if !header_ok($h, $reply); next if !header_ok($h, $reply);
@ -4336,10 +4335,10 @@ sub nic_domeneshop_update {
$config{$h}{'ip'} = $ip; $config{$h}{'ip'} = $ip;
$config{$h}{'mtime'} = $now; $config{$h}{'mtime'} = $now;
$config{$h}{'status'} = 'good'; $config{$h}{'status'} = 'good';
success("updating %s: good: IP address set to %s", $h, $ip); success("$h: IP address set to $ip");
} else { } else {
$config{$h}{'status'} = 'failed'; $config{$h}{'status'} = 'failed';
failed("updating %s: Server said: '%s' '%s'", $h, $status, $message); failed("$h: Server said: $status $message");
} }
} }
} }