Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bugfix: Long username-password-combinations will not result in an authentication error anymore.

Browse source 
If a username-password-combination is too long, perl's encode_base64 method will break the encoded string (stored in $auth) up into multiple lines of no more than 74 chars[0]. This breaks HTTP's authorization, since long values must not be folded into multiple lines[1].

[0] http://perldoc.perl.org/MIME/Base64.html
[1] http://tools.ietf.org/html/rfc7230#section-3.2.4
This commit is contained in:
dirdi 2014-09-09 03:10:08 +02:00
parent ec4ab3a636
commit b64b32d7a8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ddclient
View file

@ -1875,7 +1875,7 @@ sub geturl {
$request .= "/$url HTTP/1.0\n"; $request .= "/$url HTTP/1.0\n";
$request .= "Host: $server\n"; $request .= "Host: $server\n";
my $auth = encode_base64("${login}:${password}"); my $auth = encode_base64("${login}:${password}", "");
$request .= "Authorization: Basic $auth\n" if $login || $password; $request .= "Authorization: Basic $auth\n" if $login || $password;
$request .= "User-Agent: ${program}/${version}\n"; $request .= "User-Agent: ${program}/${version}\n";
$request .= "Connection: close\n"; $request .= "Connection: close\n";