From ba6a27918625a59207c9a2355d8fb62dd4a0775b Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Fri, 28 Jun 2024 03:40:35 -0400 Subject: [PATCH] Convert unnecessarily required variables to optional Users are not required to provide values for these variables; either the default is reasonable or the variable can be left unset. --- ddclient.in | 90 ++++++++++++++++++++++++++--------------------------- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/ddclient.in b/ddclient.in index 0a86822..578847f 100755 --- a/ddclient.in +++ b/ddclient.in @@ -587,8 +587,8 @@ my %variables = ( 'fwv4-skip' => setv(T_STRING,0, 0, undef, undef), 'fwv6' => setv(T_ANY, 0, 0, '', undef), 'fwv6-skip' => setv(T_STRING,0, 0, undef, undef), - 'fw-login' => setv(T_LOGIN, 1, 0, undef, undef), - 'fw-password' => setv(T_PASSWD,1, 0, undef, undef), + 'fw-login' => setv(T_LOGIN, 0, 0, undef, undef), + 'fw-password' => setv(T_PASSWD,0, 0, undef, undef), 'cmd' => setv(T_PROG, 0, 0, '', undef), 'cmd-skip' => setv(T_STRING,0, 0, undef, undef), 'cmdv4' => setv(T_PROG, 0, 0, '', undef), @@ -619,7 +619,7 @@ my %variables = ( 'redirect' => setv(T_NUMBER,0, 0, 0, undef) }, 'protocol-common-defaults' => { - 'server' => setv(T_FQDNP, 1, 0, 'members.dyndns.org', undef), + 'server' => setv(T_FQDNP, 0, 0, 'members.dyndns.org', undef), 'login' => setv(T_LOGIN, 1, 0, undef, undef), 'password' => setv(T_PASSWD,1, 0, undef, undef), 'host' => setv(T_STRING,1, 1, undef, undef), @@ -714,7 +714,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'api.1984.is', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.1984.is', undef), }, }, 'changeip' => { @@ -724,7 +724,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), - 'server' => setv(T_FQDNP, 1, 0, 'nic.changeip.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'nic.changeip.com', undef), }, }, 'cloudflare' => { @@ -737,9 +737,9 @@ my %protocols = ( 'login' => setv(T_LOGIN, 0, 0, 'token', undef), 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), 'mx' => setv(T_OFQDN, 0, 1, '', undef), - 'server' => setv(T_FQDNP, 1, 0, 'api.cloudflare.com/client/v4', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.cloudflare.com/client/v4', undef), 'static' => setv(T_BOOL, 0, 1, 0, undef), - 'ttl' => setv(T_NUMBER, 1, 0, 1, undef), + 'ttl' => setv(T_NUMBER, 0, 0, 1, undef), 'wildcard' => setv(T_BOOL, 0, 1, 0, undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef), }, @@ -762,7 +762,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'api.digitalocean.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.digitalocean.com', undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef), }, }, @@ -774,7 +774,7 @@ my %protocols = ( %{$variables{'protocol-common-defaults'}}, 'min-error-interval' => setv(T_DELAY, 0, 0, interval('8m'), 0), 'script' => setv(T_STRING, 0, 1, '/special/api.php', undef), - 'server' => setv(T_FQDNP, 1, 0, 'dinahosting.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dinahosting.com', undef), }, }, 'dnsmadeeasy' => { @@ -783,8 +783,8 @@ my %protocols = ( 'examples' => \&nic_dnsmadeeasy_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'script' => setv(T_STRING, 1, 1, '/servlet/updateip', undef), - 'server' => setv(T_FQDNP, 1, 0, 'cp.dnsmadeeasy.com', undef), + 'script' => setv(T_STRING, 0, 1, '/servlet/updateip', undef), + 'server' => setv(T_FQDNP, 0, 0, 'cp.dnsmadeeasy.com', undef), }, }, 'dondominio' => { @@ -793,7 +793,7 @@ my %protocols = ( 'examples' => \&nic_dondominio_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'server' => setv(T_FQDNP, 1, 0, 'dondns.dondominio.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dondns.dondominio.com', undef), }, }, 'dslreports1' => { @@ -802,7 +802,7 @@ my %protocols = ( 'examples' => \&nic_dslreports1_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'server' => setv(T_FQDNP, 1, 0, 'www.dslreports.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'www.dslreports.com', undef), }, }, 'domeneshop' => { @@ -811,7 +811,7 @@ my %protocols = ( 'examples' => \&nic_domeneshop_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'server' => setv(T_FQDNP, 1, 0, 'api.domeneshop.no', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.domeneshop.no', undef), }, }, 'duckdns' => { @@ -821,7 +821,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'www.duckdns.org', undef), + 'server' => setv(T_FQDNP, 0, 0, 'www.duckdns.org', undef), }, }, 'dyndns1' => { @@ -841,7 +841,7 @@ my %protocols = ( %{$variables{'protocol-common-defaults'}}, %{$variables{'dyndns-common-defaults'}}, 'custom' => setv(T_BOOL, 0, 1, 0, undef), - 'script' => setv(T_STRING, 1, 1, '/nic/update', undef), + 'script' => setv(T_STRING, 0, 1, '/nic/update', undef), }, }, 'easydns' => { @@ -853,8 +853,8 @@ my %protocols = ( 'backupmx' => setv(T_BOOL, 0, 1, 0, undef), 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), 'mx' => setv(T_OFQDN, 0, 1, '', undef), - 'server' => setv(T_FQDNP, 1, 0, 'api.cp.easydns.com', undef), - 'script' => setv(T_STRING, 1, 1, '/dyn/generic.php', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.cp.easydns.com', undef), + 'script' => setv(T_STRING, 0, 1, '/dyn/generic.php', undef), 'wildcard' => setv(T_BOOL, 0, 1, 0, undef), }, }, @@ -865,7 +865,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), - 'server' => setv(T_FQDNP, 1, 0, 'freedns.afraid.org', undef), + 'server' => setv(T_FQDNP, 0, 0, 'freedns.afraid.org', undef), }, }, 'freemyip' => { @@ -875,7 +875,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'freemyip.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'freemyip.com', undef), }, }, 'gandi' => { @@ -886,8 +886,8 @@ my %protocols = ( %{$variables{'protocol-common-defaults'}}, 'login' => undef, 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), - 'server' => setv(T_FQDNP, 1, 0, 'api.gandi.net', undef), - 'script' => setv(T_STRING, 1, 1, '/v5', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.gandi.net', undef), + 'script' => setv(T_STRING, 0, 1, '/v5', undef), 'use-personal-access-token' => setv(T_BOOL, 0, 0, 0, undef), 'ttl' => setv(T_DELAY, 0, 0, undef, interval('5m')), 'zone' => setv(T_FQDN, 1, 0, undef, undef), @@ -900,8 +900,8 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), - 'server' => setv(T_FQDNP, 1, 0, 'api.godaddy.com/v1/domains', undef), - 'ttl' => setv(T_NUMBER, 1, 0, 600, undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.godaddy.com/v1/domains', undef), + 'ttl' => setv(T_NUMBER, 0, 0, 600, undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef), }, }, @@ -912,7 +912,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), - 'server' => setv(T_FQDNP, 1, 0, 'domains.google.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'domains.google.com', undef), }, }, 'hetzner' => { @@ -923,7 +923,7 @@ my %protocols = ( %{$variables{'protocol-common-defaults'}}, 'login' => setv(T_LOGIN, 0, 0, 'token', undef), 'min-interval' => setv(T_DELAY, 0, 0, interval('1m'), 0), - 'server' => setv(T_FQDNP, 1, 0, 'dns.hetzner.com/api/v1', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dns.hetzner.com/api/v1', undef), 'ttl' => setv(T_NUMBER, 0, 0, 60, 60), 'zone' => setv(T_FQDN, 1, 0, undef, undef), }, @@ -935,7 +935,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), - 'server' => setv(T_FQDNP, 1, 0, 'api.mythic-beasts.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.mythic-beasts.com', undef), }, }, 'namecheap' => { @@ -945,7 +945,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), - 'server' => setv(T_FQDNP, 1, 0, 'dynamicdns.park-your-domain.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dynamicdns.park-your-domain.com', undef), }, }, 'nfsn' => { @@ -955,8 +955,8 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), - 'server' => setv(T_FQDNP, 1, 0, 'api.nearlyfreespeech.net', undef), - 'ttl' => setv(T_NUMBER, 1, 0, 300, undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.nearlyfreespeech.net', undef), + 'ttl' => setv(T_NUMBER, 0, 0, 300, undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef), }, }, @@ -967,7 +967,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'njal.la', undef), + 'server' => setv(T_FQDNP, 0, 0, 'njal.la', undef), 'quietreply' => setv(T_BOOL, 0, 1, 0, undef), }, }, @@ -978,7 +978,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'custom' => setv(T_BOOL, 0, 1, 0, undef), - 'server' => setv(T_FQDNP, 1, 0, 'dynupdate.no-ip.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dynupdate.no-ip.com', undef), 'static' => setv(T_BOOL, 0, 1, 0, undef), }, }, @@ -988,7 +988,7 @@ my %protocols = ( 'examples' => \&nic_nsupdate_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'login' => setv(T_LOGIN, 1, 0, '/usr/bin/nsupdate', undef), + 'login' => setv(T_LOGIN, 0, 0, '/usr/bin/nsupdate', undef), 'tcp' => setv(T_BOOL, 0, 1, 0, undef), 'ttl' => setv(T_NUMBER, 0, 1, 600, undef), 'zone' => setv(T_STRING, 1, 1, undef, undef), @@ -1000,8 +1000,8 @@ my %protocols = ( 'examples' => \&nic_ovh_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'script' => setv(T_STRING, 1, 1, '/nic/update', undef), - 'server' => setv(T_FQDNP, 1, 0, 'www.ovh.com', undef), + 'script' => setv(T_STRING, 0, 1, '/nic/update', undef), + 'server' => setv(T_FQDNP, 0, 0, 'www.ovh.com', undef), }, }, 'porkbun' => { @@ -1024,7 +1024,7 @@ my %protocols = ( 'examples' => \&nic_sitelutions_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'server' => setv(T_FQDNP, 1, 0, 'www.sitelutions.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'www.sitelutions.com', undef), 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), }, }, @@ -1037,8 +1037,8 @@ my %protocols = ( 'backupmx' => setv(T_BOOL, 0, 1, 0, undef), 'custom' => setv(T_BOOL, 0, 1, 0, undef), 'mx' => setv(T_OFQDN, 0, 1, '', undef), - 'script' => setv(T_STRING, 1, 1, '/nic/update', undef), - 'server' => setv(T_FQDNP, 1, 0, 'dyn.woima.fi', undef), + 'script' => setv(T_STRING, 0, 1, '/nic/update', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dyn.woima.fi', undef), 'static' => setv(T_BOOL, 0, 1, 0, undef), 'wildcard' => setv(T_BOOL, 0, 1, 0, undef), }, @@ -1050,7 +1050,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), - 'server' => setv(T_FQDNP, 1, 0, 'pddimp.yandex.ru', undef), + 'server' => setv(T_FQDNP, 0, 0, 'pddimp.yandex.ru', undef), }, }, 'zoneedit1' => { @@ -1060,7 +1060,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'min-interval' => setv(T_DELAY, 0, 0, interval('10m'), 0), - 'server' => setv(T_FQDNP, 1, 0, 'dynamic.zoneedit.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dynamic.zoneedit.com', undef), 'zone' => setv(T_OFQDN, 0, 0, undef, undef), }, }, @@ -1071,7 +1071,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'dynamicdns.key-systems.net', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dynamicdns.key-systems.net', undef), }, }, 'dnsexit2' => { @@ -1082,9 +1082,9 @@ my %protocols = ( %{$variables{'protocol-common-defaults'}}, 'login' => undef, 'ssl' => setv(T_BOOL, 0, 0, 1, undef), - 'server' => setv(T_FQDNP, 1, 0, 'api.dnsexit.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'api.dnsexit.com', undef), 'path' => setv(T_STRING, 0, 0, '/dns/', undef), - 'ttl' => setv(T_NUMBER, 1, 0, 5, 0), + 'ttl' => setv(T_NUMBER, 0, 0, 5, 0), 'zone' => setv(T_STRING, 0, 0, undef, undef), }, }, @@ -1095,7 +1095,7 @@ my %protocols = ( 'variables' => { %{$variables{'protocol-common-defaults'}}, 'login' => undef, - 'server' => setv(T_FQDNP, 1, 0, 'dyndns.regfish.de', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dyndns.regfish.de', undef), }, }, 'enom' => { @@ -1104,7 +1104,7 @@ my %protocols = ( 'examples' => \&nic_enom_examples, 'variables' => { %{$variables{'protocol-common-defaults'}}, - 'server' => setv(T_FQDNP, 1, 0, 'dynamic.name-services.com', undef), + 'server' => setv(T_FQDNP, 0, 0, 'dynamic.name-services.com', undef), 'min-interval' => setv(T_DELAY, 0, 0, 0, interval('5m')), }, },