From c0375cde091a170481239627a23e15b94e2aa066 Mon Sep 17 00:00:00 2001
From: Sandro <sandro.jaeckel@gmail.com>
Date: Fri, 30 Dec 2022 03:16:26 +0100
Subject: [PATCH] Apply suggestions from code review

---
 ddclient.in | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/ddclient.in b/ddclient.in
index 3c49c5d..22580bb 100755
--- a/ddclient.in
+++ b/ddclient.in
@@ -4492,13 +4492,13 @@ Configuration variables applicable to the 'domeneshop' api are:
   protocol=domeneshop          ##
   login=token                  ## api-token
   password=secret              ## api-secret
-  your.domain.name             ## the host registered with the service.
+    domain.example.com         ## the host registered with the service.             ## the host registered with the service.
 
 Example ${program}.conf file entries:
   ## single host update
   protocol=domeneshop
-  login=djk239023jf
-  password=32jkl23nkl2rhron89wec89023kewjkoej
+  login=username
+  password=your-password
   my.example.com
 
 EoEXAMPLE
@@ -4522,9 +4522,7 @@ sub nic_domeneshop_update {
         # Set the URL that we're going to to update
         my $url;
         $url  = $globals{'ssl'} ? "https://" : "http://";
-        $url .= "$config{$h}{'server'}$endpointPath";
-        $url .= "?hostname=$h";
-        $url .= "&myip=$ip";
+        $url .= "$config{$h}{'server'}$endpointPath?hostname=$h&myip=$ip";
 
         # Try to get URL
         my $reply = geturl(