f024bcce34
This is mostly to simplify tests, but it also improves readability.
The infrastructure changes in this commit also make it possible to
introduce a new `url` variable that defaults to `opt('server', $h)`
concatenated with `opt('script', $h)` so that we can start migrating
away from those user-unfriendly variables.
101 lines
3.4 KiB
Perl
101 lines
3.4 KiB
Perl
use Test::More;
|
|
use re qw(is_regexp);
|
|
SKIP: { eval { require Test::Warnings; } or skip($@, 1); }
|
|
eval { require 'ddclient'; } or BAIL_OUT($@);
|
|
|
|
my %variable_collections = (
|
|
map({ ($_ => $ddclient::variables{$_}) } grep($_ ne 'merged', keys(%ddclient::variables))),
|
|
map({ ("protocol=$_" => $ddclient::protocols{$_}{variables}); } keys(%ddclient::protocols)),
|
|
);
|
|
my %seen;
|
|
my @test_cases = (
|
|
map({
|
|
my $vcn = $_;
|
|
my $vc = $variable_collections{$_};
|
|
map({
|
|
my $def = $vc->{$_};
|
|
my $seen = exists($seen{$def});
|
|
$seen{$def} = undef;
|
|
({desc => "$vcn $_", def => $vc->{$_}}) x !$seen;
|
|
} sort(keys(%$vc)));
|
|
} sort(keys(%variable_collections))),
|
|
);
|
|
for my $tc (@test_cases) {
|
|
if ($tc->{def}{required}) {
|
|
is($tc->{def}{default}, undef, "'$tc->{desc}' (required) has no default");
|
|
} else {
|
|
# Preserve all existing variables in $variables{merged} so that variables with dynamic
|
|
# defaults can reference them.
|
|
local %ddclient::variables = (merged => {
|
|
%{$ddclient::variables{merged}},
|
|
'var for test' => $tc->{def},
|
|
});
|
|
# Variables with dynamic defaults will need their own unit tests, but we can still check the
|
|
# clean-slate hostless default.
|
|
local %ddclient::config;
|
|
local %ddclient::opt;
|
|
local %ddclient::globals;
|
|
my $norm;
|
|
my $default = ddclient::default('var for test');
|
|
diag("'$tc->{desc}' default: " . ($default // '<undefined>'));
|
|
is($default, $tc->{def}{default}, "'$tc->{desc}' default() return value matches default")
|
|
if ref($tc->{def}{default}) ne 'CODE';
|
|
my $valid = eval { $norm = ddclient::check_value($default, $tc->{def}); 1; } or diag($@);
|
|
ok($valid, "'$tc->{desc}' (optional) has a valid default");
|
|
is($norm, $default, "'$tc->{desc}' default normalizes to itself") if $valid;
|
|
}
|
|
}
|
|
|
|
my @use_test_cases = (
|
|
{
|
|
desc => 'clean slate hostless default',
|
|
want => 'ip',
|
|
},
|
|
{
|
|
desc => 'usage string',
|
|
host => '<usage>',
|
|
want => qr/disabled.*ip|ip.*disabled/,
|
|
},
|
|
{
|
|
desc => 'usev4 disables use by default',
|
|
host => 'host',
|
|
cfg => {usev4 => 'webv4'},
|
|
want => 'disabled',
|
|
},
|
|
{
|
|
desc => 'usev6 disables use by default',
|
|
host => 'host',
|
|
cfg => {usev4 => 'webv4'},
|
|
want => 'disabled',
|
|
},
|
|
{
|
|
desc => 'explicitly setting use re-enables it',
|
|
host => 'host',
|
|
cfg => {use => 'web', usev4 => 'webv4'},
|
|
want => 'web',
|
|
},
|
|
);
|
|
for my $tc (@use_test_cases) {
|
|
my $desc = "'use' dynamic default: $tc->{desc}";
|
|
local %ddclient::protocols =
|
|
(protocol => {variables => $ddclient::variables{'protocol-common-defaults'}});
|
|
local %ddclient::variables = (merged => {
|
|
'protocol' => $ddclient::variables{'merged'}{'protocol'},
|
|
'use' => $ddclient::variables{'protocol-common-defaults'}{'use'},
|
|
'usev4' => $ddclient::variables{'merged'}{'usev4'},
|
|
'usev6' => $ddclient::variables{'merged'}{'usev6'},
|
|
});
|
|
local %ddclient::config = (host => {protocol => 'protocol', %{$tc->{cfg} // {}}});
|
|
local %ddclient::opt;
|
|
local %ddclient::globals;
|
|
|
|
my $got = ddclient::opt('use', $tc->{host});
|
|
|
|
if (is_regexp($tc->{want})) {
|
|
like($got, $tc->{want}, $desc);
|
|
} else {
|
|
is($got, $tc->{want}, $desc);
|
|
}
|
|
}
|
|
|
|
done_testing();
|