Fabio/hassio-supervised-installer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Properly check for enabled ModemManager service (#141)

Browse source 
A systemd service may be marked as enabled as vendor preset, and this
breaks the check we used to check if it was active.

Here's what you get in an Ubuntu 20.04 installation:

❯ sudo systemctl status ModemManager
● ModemManager.service - Modem Manager
     Loaded: loaded (/lib/systemd/system/ModemManager.service; disabled; vendor preset: enabled)
     Active: inactive (dead)

❯ systemctl list-unit-files ModemManager.service
UNIT FILE            STATE    VENDOR PRESET
ModemManager.service disabled enabled

1 unit files listed

While the list-unit-files can be filtered using `--state=enabled`, we
can just rely on `systemctl is-enabled` instead.
This commit is contained in:
Marco Trevisan 2020-12-29 13:45:38 +01:00 committed by GitHub
parent e2a66e35d3
commit 52e6529bf0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
installer.sh
View file

@ -63,7 +63,7 @@ if [ ! -z "${MISSING_PACKAGES}" ]; then
fi fi
# Check if Modem Manager is enabled # Check if Modem Manager is enabled
if systemctl list-unit-files ModemManager.service | grep enabled > /dev/null 2>&1; then if systemctl is-enabled ModemManager.service &> /dev/null; then
warn "ModemManager service is enabled. This might cause issue when using serial devices." warn "ModemManager service is enabled. This might cause issue when using serial devices."
fi fi