style: Quote variables (#323)

.github/workflows/check.yml

@@ -11,4 +11,4 @@ jobs:
       - name: Run ShellCheck
         uses: ludeeus/action-shellcheck@master
 env:
-        SHELLCHECK_OPTS: -x --source-path=src -e SC2001 -e SC2223 -e SC2034 -e SC2064 -e SC2317 -e SC2153
+        SHELLCHECK_OPTS: -x --source-path=src -e SC2001 -e SC2034 -e SC2064 -e SC2317 -e SC2153

src/boot.sh

@@ -3,7 +3,7 @@ set -Eeuo pipefail
 
 # Docker environment variables
 
-: ${BOOT_MODE:='legacy'}  # Boot mode
+: "${BOOT_MODE:='legacy'}"  # Boot mode
 
 SECURE=""
 BOOT_OPTS=""

src/disk.sh

@@ -3,12 +3,12 @@ set -Eeuo pipefail
 
 # Docker environment variables
 
-: ${DISK_IO:='native'}          # I/O Mode, can be set to 'native', 'threads' or 'io_turing'
+: "${DISK_IO:='native'}"          # I/O Mode, can be set to 'native', 'threads' or 'io_turing'
-: ${DISK_FMT:=''}            # Disk file format, can be set to "raw" or "qcow2" (default)
+: "${DISK_FMT:=''}"            # Disk file format, can be set to "raw" or "qcow2" (default)
-: ${DISK_FLAGS:=''}             # Specifies the options for use with the qcow2 disk format
+: "${DISK_FLAGS:=''}"             # Specifies the options for use with the qcow2 disk format
-: ${DISK_CACHE:='none'}         # Caching mode, can be set to 'writeback' for better performance
+: "${DISK_CACHE:='none'}"         # Caching mode, can be set to 'writeback' for better performance
-: ${DISK_DISCARD:='on'}         # Controls whether unmap (TRIM) commands are passed to the host.
+: "${DISK_DISCARD:='on'}"         # Controls whether unmap (TRIM) commands are passed to the host.
-: ${DISK_ROTATION:='1'}         # Rotation rate, set to 1 for SSD storage and increase for HDD
+: "${DISK_ROTATION:='1'}"         # Rotation rate, set to 1 for SSD storage and increase for HDD
 
 BOOT="$STORAGE/$BASE"
 DRIVERS="$STORAGE/drivers.img"
@@ -449,14 +449,14 @@ else
   DISK_ALLOC="preallocation=falloc"
 fi
 
-: ${DISK2_SIZE:=''}
+: "${DISK2_SIZE:=''}"
-: ${DISK3_SIZE:=''}
+: "${DISK3_SIZE:=''}"
-: ${DISK4_SIZE:=''}
+: "${DISK4_SIZE:=''}"
 
-: ${DEVICE:=''}        # Docker variables to passthrough a block device, like /dev/vdc1.
+: "${DEVICE:=''}"        # Docker variables to passthrough a block device, like /dev/vdc1.
-: ${DEVICE2:=''}
+: "${DEVICE2:=''}"
-: ${DEVICE3:=''}
+: "${DEVICE3:=''}"
-: ${DEVICE4:=''}
+: "${DEVICE4:=''}"
 
 if [ -n "$DEVICE" ]; then
   addDevice "userdata" "$DEVICE" "device" "1" "0xa" || exit $?

src/display.sh

@@ -3,8 +3,8 @@ set -Eeuo pipefail
 
 # Docker environment variables
 
-: ${GPU:='N'}           # GPU passthrough
+: "${GPU:='N'}"           # GPU passthrough
-: ${DISPLAY:='none'}  # Display type
+: "${DISPLAY:='none'}"  # Display type
 
 case "${DISPLAY,,}" in
   vnc)

src/network.sh

@@ -3,18 +3,18 @@ set -Eeuo pipefail
 
 # Docker environment variables
 
-: ${DHCP:='N'}
+: "${DHCP:='N'}"
-: ${HOST_PORTS:=''}
+: "${HOST_PORTS:=''}"
-: ${MAC:='82:cf:d0:5e:57:66'}
+: "${MAC:='82:cf:d0:5e:57:66'}"
 
-: ${VM_NET_DEV:=''}
+: "${VM_NET_DEV:=''}"
-: ${VM_NET_TAP:='qemu'}
+: "${VM_NET_TAP:='qemu'}"
-: ${VM_NET_MAC:="$MAC"}
+: "${VM_NET_MAC:="$MAC"}"
-: ${VM_NET_HOST:='QEMU'}
+: "${VM_NET_HOST:='QEMU'}"
 
-: ${DNSMASQ_OPTS:=''}
+: "${DNSMASQ_OPTS:=''}"
-: ${DNSMASQ:='/usr/sbin/dnsmasq'}
+: "${DNSMASQ:='/usr/sbin/dnsmasq'}"
-: ${DNSMASQ_CONF_DIR:='/etc/dnsmasq.d'}
+: "${DNSMASQ_CONF_DIR:='/etc/dnsmasq.d'}"
 
 ADD_ERR="Please add the following setting to your container:"
 

src/proc.sh

@@ -3,9 +3,9 @@ set -Eeuo pipefail
 
 # Docker environment variables
 
-: ${KVM:='Y'}
+: "${KVM:='Y'}"
-: ${CPU_MODEL:='host'}
+: "${CPU_MODEL:='host'}"
-: ${CPU_FEATURES:='+ssse3,+sse4.1,+sse4.2'}
+: "${CPU_FEATURES:='+ssse3,+sse4.1,+sse4.2'}"
 
 [ "$ARCH" != "amd64" ] && KVM="N"
 

src/reset.sh

@@ -11,13 +11,13 @@ trap 'error "Status $? while: $BASH_COMMAND (line $LINENO/$BASH_LINENO)"' ERR
 
 # Docker environment variables
 
-: ${BOOT:=''}           # URL of the ISO file
+: "${BOOT:=''}"           # URL of the ISO file
-: ${DEBUG:='N'}         # Disable debugging
+: "${DEBUG:='N'}"         # Disable debugging
-: ${ALLOCATE:=''}       # Preallocate diskspace
+: "${ALLOCATE:=''}"       # Preallocate diskspace
-: ${ARGUMENTS:=''}      # Extra QEMU parameters
+: "${ARGUMENTS:=''}"      # Extra QEMU parameters
-: ${CPU_CORES:='1'}     # Amount of CPU cores
+: "${CPU_CORES:='1'}"     # Amount of CPU cores
-: ${RAM_SIZE:='1G'}     # Maximum RAM amount
+: "${RAM_SIZE:='1G'}"     # Maximum RAM amount
-: ${DISK_SIZE:='16G'}   # Initial data disk size
+: "${DISK_SIZE:='16G'}"   # Initial data disk size
 
 # Helper variables