From 1036155c9ef0cc58c3f5a48702f6cb7b8dcea6b6 Mon Sep 17 00:00:00 2001 From: Nathan Reed Date: Wed, 31 Jul 2024 17:05:07 +0000 Subject: [PATCH] feat: allow deprecated formatQuality with logged warning Signed-off-by: Nathan Reed --- src/serve_rendered.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/serve_rendered.js b/src/serve_rendered.js index 513a042..2043ce3 100644 --- a/src/serve_rendered.js +++ b/src/serve_rendered.js @@ -504,6 +504,15 @@ const respondImage = ( image.composite(composites); } + // Legacy formatQuality is deprecated but still works + const formatQualities = options.formatQuality || {}; + if (Object.keys(formatQualities).length !== 0) { + console.log( + 'WARNING: The formatQuality option is deprecated and has been replaced with formatOptions. Please see the documentation. The values from formatQuality will be used if a quality setting is not provided via formatOptions.', + ); + } + const formatQuality = formatQualities[format]; + const formatOptions = (options.formatOptions || {})[format] || {}; if (format === 'png') { @@ -518,9 +527,9 @@ const respondImage = ( dither: formatOptions.dither, }); } else if (format === 'jpeg') { - image.jpeg({ quality: formatOptions.quality || 80 }); + image.jpeg({ quality: formatOptions.quality || formatQuality || 80 }); } else if (format === 'webp') { - image.webp({ quality: formatOptions.quality || 90 }); + image.webp({ quality: formatOptions.quality || formatQuality || 90 }); } image.toBuffer((err, buffer, info) => { if (!buffer) {