From 3246df75b6516309479beffb0948fd3233caa57b Mon Sep 17 00:00:00 2001 From: Bill Church Date: Tue, 22 Aug 2023 09:16:10 -0400 Subject: [PATCH] fix: cols and rows were not properly assigned for terminal (#337) * fix: set correct vars and cols property * fix: add cols and rows to session.ssh property * style: remove const assignment --------- Co-authored-by: w-v Co-authored-by: bc 064 <87337961+bcvort@users.noreply.github.com> --- app/server/app.js | 3 ++- app/server/routes.js | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/server/app.js b/app/server/app.js index 3a1ece5..195b614 100644 --- a/app/server/app.js +++ b/app/server/app.js @@ -102,7 +102,8 @@ const onConnection = (socket) => { }); socket.on('geometry', (cols, rows) => { // TODO need to rework how we pass settings to ssh2, this is less than ideal - socket.request.session.ssh.terminfo = { cols, rows }; + socket.request.session.ssh.cols = cols; + socket.request.session.ssh.rows = rows; webssh2debug(socket, `SOCKET GEOMETRY: termCols = ${cols}, termRows = ${rows}`); }); }; diff --git a/app/server/routes.js b/app/server/routes.js index 5276742..c1ea3f9 100644 --- a/app/server/routes.js +++ b/app/server/routes.js @@ -171,6 +171,8 @@ exports.connect = function connect(req, res) { letterSpacing, lineHeight, }, + cols: null, + rows: null, allowreplay: config.options.challengeButton || (validator.isBoolean(`${req.headers.allowreplay}`)