Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nic_updateable: Remove unnecessary force_update parameter

Browse source 
`nic_updateable` can look up the host's `force_update` function itself
so there's no need to pass it as an argument.
This commit is contained in:
Richard Hansen 2024-07-26 17:23:21 -04:00
parent 0ffffb1400
commit 38a4e9eeef
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ddclient.in
View file

@ -1366,7 +1366,6 @@ sub update_nics {
for my $p (sort keys %protocols) {
my (@hosts, %ipsv4, %ipsv6) = ();
my $force_update = $protocols{$p}{'force_update'};
my $update = $protocols{$p}{'update'};
for my $h (sort keys %config) {
@ -1461,7 +1460,7 @@ sub update_nics {
next;
}
next if !nic_updateable($h, $force_update);
next if !nic_updateable($h);
push @hosts, $h;
$ipsv4{$ipv4} = $h if ($ipv4);
@ -3527,8 +3526,8 @@ EoEXAMPLE
## Returns true if we can go ahead and update the IP address at server
######################################################################
sub nic_updateable {
my $host = shift;
my $sub = shift;
my ($host) = @_;
my $force_update = $protocols{$config{$host}{protocol}}{force_update};
my $update = 0;
my $ip = $config{$host}{'wantip'};
my $ipv4 = $config{$host}{'wantipv4'};
@ -3708,7 +3707,7 @@ sub nic_updateable {
$update = 1;
}
} elsif (defined($sub) && &$sub($host)) {
} elsif (defined($force_update) && $force_update->($host)) {
$update = 1;
} elsif ((defined($recap{$host}{'static'}) && defined($config{$host}{'static'}) &&
($recap{$host}{'static'} ne $config{$host}{'static'})) ||