Richard Hansen
e32b9436fb
nfsn: Fix type of min-interval
variable
2024-06-28 15:28:44 -04:00
Richard Hansen
66bb07450f
nfsn: Fix spelling of min-interval
variable name
2024-06-28 15:28:44 -04:00
Richard Hansen
5757f7e07d
Restore accidentally deleted --fw
command-line argument
...
This was mistakenly deleted in commit
908b728503
.
2024-06-27 00:10:35 -04:00
Richard Hansen
f4c4d974d2
Merge pull request #692 from rhansen/infomaniak
...
`infomaniak` fixes
2024-06-25 22:56:44 -04:00
Richard Hansen
948567c456
infomaniak: Unrequire server
setting
...
The `infomaniak` protocol doesn't use `server`.
2024-06-25 22:53:23 -04:00
Richard Hansen
9ba583175a
infomaniak: Fail if the HTTP status code is not 2xx
2024-06-25 22:53:23 -04:00
Richard Hansen
7d99da77cc
header_ok: Fail if the reply is falsy
2024-06-25 22:53:23 -04:00
Richard Hansen
8e24c92b1e
infomaniak: Fix response parsing
2024-06-25 22:53:23 -04:00
Richard Hansen
d2f0e042f4
infomaniak: Invert condition to improve readability
2024-06-25 22:47:26 -04:00
Richard Hansen
29e86d9a91
infomaniak: Rename variable for readability
2024-06-25 22:47:25 -04:00
Richard Hansen
a5dedeed3c
infomaniak: Fix geturl call
...
* Pass login and password via `login` and `password` options to
avoid issues with escaping special characters.
* Don't attempt twice -- if the first attempt fails, the second will
almost certainly fail as well. (The two attempted URLs were
equivalent, differing only in how the login and password were
passed.)
2024-06-25 22:47:25 -04:00
Richard Hansen
ac9f937c88
infomaniak: Delete unnecessary defined checks
...
`undef` is falsy so there's no need to check whether the value is
defined.
2024-06-25 22:46:00 -04:00
Richard Hansen
bab9d9483e
infomaniak: Move variable declaration to definition
2024-06-25 21:55:46 -04:00
Richard Hansen
134e47b61d
infomaniak: Delete unnecessary newlines
2024-06-25 21:50:51 -04:00
Richard Hansen
e0d9bcc36d
Merge pull request #691 from rhansen/fixes
...
Fix `regfishde` IPv6 support, repeated `infomaniak` force updates, and other minor issues
2024-06-25 03:00:20 -04:00
Richard Hansen
9d49a33ac6
regfishde: Fix IPv6 support
2024-06-25 02:58:09 -04:00
Richard Hansen
0cde2e3f96
infomaniak: Fix mtime
update
...
`mtime` should always be updated whenever the IP address is updated,
otherwise ddclient will keep force updating over and over.
2024-06-25 02:57:42 -04:00
Richard Hansen
61577d29ae
njalla: Fix configuration change during update
...
If the user enabled `quietreply`, it should not become false after the
first update.
Users might not notice a problem because I think ddclient re-reads the
config file before every check.
2024-06-25 02:52:22 -04:00
Richard Hansen
32bf975bfa
Fix call to wrong function name with bad --usev6
2024-06-25 02:52:22 -04:00
Richard Hansen
99dfd7f84d
Don't assume that --use
is defined
2024-06-25 02:51:58 -04:00
Richard Hansen
b154d8ef98
Fix missing v4, v6 variants in recap update
...
Fixes an oversight when IPv6 support was added.
2024-06-25 02:48:51 -04:00
Richard Hansen
dafde8becb
Fix erroneous backupmx
recap check for dyndns1
, dyndns2
2024-06-25 01:38:43 -04:00
Richard Hansen
7ac6eda7cc
Fix missing local use*
override in --query
2024-06-25 01:37:47 -04:00
Richard Hansen
c7c8c5f097
Fix usev4
, usev6
output for --query
2024-06-25 01:32:27 -04:00
Richard Hansen
27b50a3b93
Fix --usev4=cisco
, --usev4=cisco-asa
warning messages
2024-06-25 01:29:29 -04:00
Richard Hansen
e1e8d5711a
Fix get_ip
argument in --query
when testing --fw
2024-06-25 01:20:30 -04:00
Richard Hansen
b363fb48a5
Fix string equality check
...
The `$proto` interpolation wasn't quoted with `\Q` and `\E`, so
metacharacters in `$proto` could break the matching. Switch from a
regex to an expression to fix the equality check and improve
readability.
2024-06-25 00:50:22 -04:00
Richard Hansen
61539105bd
Merge pull request #689 from rhansen/readability
...
Readability improvements
2024-06-22 17:32:27 -04:00
Richard Hansen
1be8438c70
Rename updateable
to force_update
for readability
2024-06-22 03:07:49 -04:00
Richard Hansen
b426b370fd
Rename %cache
to %recap
for readability
2024-06-22 02:48:03 -04:00
Richard Hansen
49bd1b7347
Rename %services
to %protocols
for consistency
2024-06-22 02:42:51 -04:00
Richard Hansen
1718ceab70
Add comments documenting the cached variables
2024-06-22 02:35:01 -04:00
Richard Hansen
3d73e7c231
Add TODO comments for confusing bits of code
2024-06-22 02:30:01 -04:00
Richard Hansen
9a5500a667
Improve readability via minor logic tweaks
...
Change some code that is unnecessarily complicated or otherwise not
the right tool for the job to improve readability.
2024-06-22 02:30:01 -04:00
Richard Hansen
ab60675660
Improve readability of cache var update logic
2024-06-22 02:30:01 -04:00
Richard Hansen
0d712f7bbc
Improve readability of wantip
, wantipv4
, wantipv6
fallback
2024-06-22 02:30:01 -04:00
Richard Hansen
5c38af2ed5
Improve readability by moving code out of unnecessary blocks
...
Invert conditions and move out unnecessary blocks to reduce
indentation and make it easier to see control flow.
2024-06-22 02:28:12 -04:00
Richard Hansen
160344514f
Improve readability by simplifying if
conditions
2024-06-22 02:27:44 -04:00
Richard Hansen
288a30ab1e
Whitespace fixes
2024-06-22 01:38:28 -04:00
Richard Hansen
afa6db8129
Merge pull request #687 from rhansen/ci
...
ci: Switch from RedHat UBI to AlmaLinux
2024-06-06 20:22:47 -04:00
Richard Hansen
0c42478ea7
ci: Switch from RedHat UBI to AlmaLinux
2024-06-06 20:16:07 -04:00
Richard Hansen
1ee64537df
Merge pull request #686 from rhansen/header_ok
...
Minor improvements to `header_ok` utility function
2024-06-06 19:40:44 -04:00
Richard Hansen
2d4a93d5e7
header_ok: Fix typo(?) in HTTP response regular expression
2024-06-06 19:34:06 -04:00
Richard Hansen
211d59fccc
header_ok: Log all non-2xx HTTP status codes
2024-06-06 19:34:06 -04:00
Richard Hansen
7fe7fd0e18
header_ok: Refactor for readability
2024-06-06 19:34:06 -04:00
Richard Hansen
adbac91be7
header_ok: Only keep first line of argument
...
This allows callers to pass the entire response without generating
overly long error messages.
2024-06-06 19:34:06 -04:00
Richard Hansen
b58a10b3e3
header_ok: Add unit tests
2024-06-06 19:34:06 -04:00
Richard Hansen
a486d4f976
Merge pull request #685 from rhansen/module-load
...
Improve loading of optional SHA1 and JSON modules
2024-06-06 19:10:21 -04:00
Richard Hansen
bb658d763a
Simplify loading of JSON::PP
2024-06-06 19:08:15 -04:00
Richard Hansen
1401ff4aea
Only attempt to load Digest::SHA
...
`Digest::SHA` has been a core module for a long time, and
`Digest::SHA1` has not been updated in a long time.
2024-06-06 19:07:25 -04:00