Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1102 commits 2 branches 15 tags 3.5 MiB
Commit graph

1102 commits

This branch
This branch
All branches
Author SHA1 Message Date
Richard Hansen
e8a6d1479f godaddy: Remove unnecessary host groupings 
Each host is already updated individually so there's no point in
grouping the hosts.
 2024-07-13 04:08:35 -04:00
Richard Hansen
5db77f7c31 zoneedit1: Add TODO comments for problematic bits of code 2024-07-13 04:08:35 -04:00
Richard Hansen
217bc998fc easydns: Remove unnecessary single host groupings 2024-07-13 04:08:35 -04:00
Richard Hansen
c8ee25ef82 noip: Remove unused attributes from group_hosts_by arguments 2024-07-13 04:08:35 -04:00
Richard Hansen
1faa315794 noip: Delete unused variables 2024-07-13 04:08:35 -04:00
Richard Hansen
39e3322fc0 dyndns2: Add missing script to group_hosts_by attributes 2024-07-13 04:08:35 -04:00
Richard Hansen
161c623557 Whitespace fixes 2024-07-13 04:08:33 -04:00
Richard Hansen
b488cb2235 Unwrap error message 
Normally I prefer lines to be less than 100 characters long, but error
messages are an exception because it makes it easier to search the
source code for the error message.
 2024-07-12 18:00:38 -04:00
Richard Hansen
4d9d0646cf Delete unnecessary comments 2024-07-12 18:00:38 -04:00
Richard Hansen
2e26a63c2f
Merge pull request #698 from rhansen/tests 
t/get_ip_from_if.pl test improvements
 2024-07-11 00:35:22 -04:00
Richard Hansen
fa0bfde3cb Don't assume the default interface has a globally routable IP 2024-07-11 00:18:27 -04:00
Richard Hansen
6af76afde9 Use skip_all if test precondition is not met 
Subtests can't have zero checks.
 2024-07-11 00:18:27 -04:00
Richard Hansen
01d2db06c1 Invert conditions for readability 2024-07-11 00:18:27 -04:00
Richard Hansen
6e7a4fb460 Split subtest into two subtests 
This makes it easier to debug failures.
 2024-07-11 00:18:27 -04:00
Richard Hansen
7b6f640c9b ci: Remove Red Hat UBI 7 
UBI 7 is at end of maintenance and can't run newer versions of node
used by some workflows.
 2024-07-11 00:15:34 -04:00
Richard Hansen
ab9ac65f46
Merge pull request #694 from rhansen/vars 
More variable fixes
 2024-06-29 04:18:57 -04:00
Richard Hansen
f5b369a7ef Fix undef warning when encountering an unset but required var 
This fixes a bug probably introduced in commit
b8a0a26441
 2024-06-29 04:14:57 -04:00
Richard Hansen
89c84f9f07 Ignore (with warning) unknown vars in --options 2024-06-29 04:14:35 -04:00
Richard Hansen
1f31b0e570 Prevent autovivification of empty definitions for unknown variables 2024-06-29 04:14:35 -04:00
Richard Hansen
d8317a730d Fix die that should be return undef 
I got ahead of myself -- I intend to replace `return undef` with `die`
in a future commit, and somehow this one jumped the gun.

This fixes a bug introduced in commit
eab72ef6d7
 2024-06-29 04:14:31 -04:00
Richard Hansen
04bdd68415 Always set the host variable 
The `host` variable is required, so always set it to avoid error
messages when validating the host configuration.
 2024-06-29 04:14:02 -04:00
Richard Hansen
be3c2060eb Fix undefined hash reference warning 
This fixes a bug introduced in commit
5e3e10d32e

For some reason Perl is OK with:

    my $x = undef;
    my @k = keys(%$x);  # empty list, no warnings

but not:

    my $x = undef;
    my %h = %$x;
    my @k = keys(%h);
 2024-06-29 04:13:57 -04:00
Richard Hansen
de39ac7bcc Fix undef warning when daemon is unset 
This fixes a bug introduced in commit
88eb2ed4fe
 2024-06-29 03:10:51 -04:00
Richard Hansen
ae7a9dce2a Fix variable name typo 
This fixes a bug introduced in commit
b154d8ef98
 2024-06-29 03:10:51 -04:00
Richard Hansen
76900c708c
Merge pull request #693 from rhansen/vars 
Variable fixes: required vs. optional, default values
 2024-06-28 16:18:26 -04:00
Richard Hansen
49f5551764 Add variable default value tests 2024-06-28 15:53:40 -04:00
Richard Hansen
eab72ef6d7 Require a defined value if the variable is required 2024-06-28 15:53:40 -04:00
Richard Hansen
399f8a8b32 Adjust variable defaults to pass validity checks 
Change the default of every variable whose default (non-`undef`)
doesn't pass through `check_value` unmodified.
 2024-06-28 15:53:40 -04:00
Richard Hansen
88eb2ed4fe Use undef as the default of truly optional variables 2024-06-28 15:53:39 -04:00
Richard Hansen
ba6a279186 Convert unnecessarily required variables to optional 
Users are not required to provide values for these variables; either
the default is reasonable or the variable can be left unset.
 2024-06-28 15:53:06 -04:00
Richard Hansen
b8a0a26441 Remove defaults from required variables without sensible defaults 
Required variables with defaults don't make sense; remove the default
values on variables that don't have sensible defaults, such as login
and password.
 2024-06-28 15:50:35 -04:00
Richard Hansen
be9e305e73 Fix definition of wtime variable 2024-06-28 15:28:44 -04:00
Richard Hansen
e32b9436fb nfsn: Fix type of min-interval variable 2024-06-28 15:28:44 -04:00
Richard Hansen
66bb07450f nfsn: Fix spelling of min-interval variable name 2024-06-28 15:28:44 -04:00
Richard Hansen
5757f7e07d Restore accidentally deleted --fw command-line argument 
This was mistakenly deleted in commit
908b728503.
 2024-06-27 00:10:35 -04:00
Richard Hansen
f4c4d974d2
Merge pull request #692 from rhansen/infomaniak 
`infomaniak` fixes
 2024-06-25 22:56:44 -04:00
Richard Hansen
948567c456 infomaniak: Unrequire server setting 
The `infomaniak` protocol doesn't use `server`.
 2024-06-25 22:53:23 -04:00
Richard Hansen
9ba583175a infomaniak: Fail if the HTTP status code is not 2xx 2024-06-25 22:53:23 -04:00
Richard Hansen
7d99da77cc header_ok: Fail if the reply is falsy 2024-06-25 22:53:23 -04:00
Richard Hansen
8e24c92b1e infomaniak: Fix response parsing 2024-06-25 22:53:23 -04:00
Richard Hansen
d2f0e042f4 infomaniak: Invert condition to improve readability 2024-06-25 22:47:26 -04:00
Richard Hansen
29e86d9a91 infomaniak: Rename variable for readability 2024-06-25 22:47:25 -04:00
Richard Hansen
a5dedeed3c infomaniak: Fix geturl call 
* Pass login and password via `login` and `password` options to
    avoid issues with escaping special characters.
  * Don't attempt twice -- if the first attempt fails, the second will
    almost certainly fail as well.  (The two attempted URLs were
    equivalent, differing only in how the login and password were
    passed.)
 2024-06-25 22:47:25 -04:00
Richard Hansen
ac9f937c88 infomaniak: Delete unnecessary defined checks 
`undef` is falsy so there's no need to check whether the value is
defined.
 2024-06-25 22:46:00 -04:00
Richard Hansen
bab9d9483e infomaniak: Move variable declaration to definition 2024-06-25 21:55:46 -04:00
Richard Hansen
134e47b61d infomaniak: Delete unnecessary newlines 2024-06-25 21:50:51 -04:00
Richard Hansen
e0d9bcc36d
Merge pull request #691 from rhansen/fixes 
Fix `regfishde` IPv6 support, repeated `infomaniak` force updates, and other minor issues
 2024-06-25 03:00:20 -04:00
Richard Hansen
9d49a33ac6 regfishde: Fix IPv6 support 2024-06-25 02:58:09 -04:00
Richard Hansen
0cde2e3f96 infomaniak: Fix mtime update 
`mtime` should always be updated whenever the IP address is updated,
otherwise ddclient will keep force updating over and over.
 2024-06-25 02:57:42 -04:00
Richard Hansen
61577d29ae njalla: Fix configuration change during update 
If the user enabled `quietreply`, it should not become false after the
first update.

Users might not notice a problem because I think ddclient re-reads the
config file before every check.
 2024-06-25 02:52:22 -04:00