Fabio/webssh2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: cols and rows were not properly assigned for terminal (#337)

Browse source 
* fix: set correct vars and cols property

* fix: add cols and rows to session.ssh property

* style: remove const assignment

---------

Co-authored-by: w-v <wtv@protonmail.ch>
Co-authored-by: bc 064 <87337961+bcvort@users.noreply.github.com>
This commit is contained in:
Bill Church 2023-08-22 09:16:10 -04:00 committed by GitHub
parent acb4e42fde
commit 3246df75b6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/server/app.js
View file

@ -102,7 +102,8 @@ const onConnection = (socket) => {
}); });
socket.on('geometry', (cols, rows) => { socket.on('geometry', (cols, rows) => {
// TODO need to rework how we pass settings to ssh2, this is less than ideal // TODO need to rework how we pass settings to ssh2, this is less than ideal
socket.request.session.ssh.terminfo = { cols, rows }; socket.request.session.ssh.cols = cols;
socket.request.session.ssh.rows = rows;
webssh2debug(socket, `SOCKET GEOMETRY: termCols = ${cols}, termRows = ${rows}`); webssh2debug(socket, `SOCKET GEOMETRY: termCols = ${cols}, termRows = ${rows}`);
}); });
}; };

2
app/server/routes.js
View file

@ -171,6 +171,8 @@ exports.connect = function connect(req, res) {
letterSpacing, letterSpacing,
lineHeight, lineHeight,
}, },
cols: null,
rows: null,
allowreplay: allowreplay:
config.options.challengeButton || config.options.challengeButton ||
(validator.isBoolean(`${req.headers.allowreplay}`) (validator.isBoolean(`${req.headers.allowreplay}`)